slachiewicz opened a new pull request, #649: URL: https://github.com/apache/maven-jar-plugin/pull/649
Moves 26 ITs that only check how jar and test-jar parameters shape the archive (includes and excludes, classifiers, skip and skipIfEmpty, attach, manifest entries and templates, automatic module names, Multi-Release detection, module descriptors) into mojo tests that run `JarMojo`/`TestJarMojo` and the real archivers in a temporary directory, keeping each IT's assertions. Some are stronger than before: MJAR-260-valid now checks the manifest entry, not only that the jar exists. Each new test fails when the production line it guards is broken. `maven-model` is declared `provided`, since the tests use it directly. The module-descriptor tests compile their sources at run time and need JDK 9+; they are skipped on JDK 8. Part of apache/maven#13822. Verified: unit tests 3 → 31 (JDK 21; on JDK 8, 31 run, 2 skipped); `mvn -B -P run-its verify` → Passed: 9, Failed: 0, Skipped: 3 (ITs 38 → 12); the timestamp test passes under three time zones --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [x] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
