slachiewicz opened a new pull request, #381:
URL: https://github.com/apache/maven-fluido-skin/pull/381
Follow-up to the Bootstrap 5.3 move on master, before 2.2.0 is released.
- **Side menu on phones** — open by default, also with JavaScript off; a
button (shown by `fluido.js`) hides and
shows it and flips `aria-expanded`. Nothing is stored. The Bootstrap
offcanvas panel is gone, and the menu comes
before the content in the page source again, as in 2.1.0 (this undoes the
source-order part of `d745fcd`).
- **Link colours** — the 4.5:1 fix from `be15162` was lost with Bootstrap 5,
whose default `#0d6efd` is 4.5:1 only
on pure white. Links are `#0a58ca` (hover `#084298`), at least 5.9:1 on
the tinted boxes sites use; dark mode
`#6ea8fe` (hover `#9ec5fe`).
- **Google Analytics and Google Search removed** — both made requests to
Google (Universal Analytics no longer
works anyway). The options are ignored; ITs check that sites setting them
still build and contain no Google
reference.
- **Theme switch only with `darkThemeEnabled`** — without it there is no
switch and `fluido-theme.js` is neither
linked nor copied.
- **Migration guide** (`migrate-2.2.md`, linked from the index and the
menu): option changes, a Bootstrap 2 → 5
class table, removed files, how to stay on 2.1.0. Checked against the diff
from the 2.1.0 tag.
Checks:
- `mvn clean install -Prun-its`: all ITs pass, RAT passes.
- maven-site (`e1f26c33`) and maven-compiler-plugin rendered with this
branch: every page URL and content anchor of
the 2.1.0 render is kept (300 pages / 2,223 anchors; 62 pages / 775
anchors, including goal-page parameters), no
request outside apache.org, no sideways scroll at 375 px, every menu link
reachable at 375 px with JavaScript off.
- axe (WCAG 2.2 AA, all rules, no exclusions) on all 300 maven-site pages:
one violation left, a content checkbox on
`component-reference-documentation-helper.html` (fixed in a maven-site
PR). With 2.1.0 every page failed.
- At 375 px the menu button hides and shows the menu; after a reload it is
open again; nothing in storage or cookies.
Known limit, documented in the guide: with `topBarEnabled`, the top-bar
menus on phones still need JavaScript
(Bootstrap collapse and dropdowns).
---
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](https://www.apache.org/licenses/LICENSE-2.0)
check one of the following:
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
- [ ] I hereby declare that I have filed an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
