slachiewicz opened a new pull request, #679: URL: https://github.com/apache/maven-war-plugin/pull/679
Moves 17 ITs that only check how war parameters shape the output (web-resource filtering and encodings, manifests, empty directories, packaging excludes, archived and attached classes, overlays, skip, the Jakarta servlet check) into unit tests, keeping each IT's assertions, and removes 9 ITs that existing unit tests already cover. MWAR-240's cited test ran with `archiveClasses=false`, so that branch was untested; `testAttachArchivedClasses` covers it. Each new test fails when the production line it guards is broken. The ITs that exercise lifecycle behaviour, real dependency resolution or reactors stay. Part of apache/maven#13822. Verified: unit tests 77 → 95, all pass, also with `-Dfile.encoding=ISO-8859-1 -Duser.language=tr -Duser.timezone=Pacific/Kiritimati`; `mvn -B -P run-its verify` → ITs 35 → 9, all pass --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [x] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
