gnodet-bot commented on code in PR #13837:
URL: https://github.com/apache/maven/pull/13837#discussion_r4477468495
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/resolver/OriginBoundAuthenticationSelector.java:
##########
@@ -44,25 +44,34 @@
* previous behaviour unless {@code strict} scope is requested, and a warning
naming the target origin
* is emitted once per id/origin pair.
*
- * @see DefaultRepositorySystemSessionFactory#MAVEN_REPOSITORY_CREDENTIAL_SCOPE
+ * <p>
+ * Used by the Maven CLI session factory and by the standalone API runner, so
both scope credentials the same way.
+ *
+ * @see #CREDENTIAL_SCOPE
*/
-class OriginBoundAuthenticationSelector implements AuthenticationSelector {
+public final class OriginBoundAuthenticationSelector implements
AuthenticationSelector {
+ /**
+ * User or system property selecting the credential scope: {@value
#SCOPE_ORIGIN} (default),
+ * {@value #SCOPE_STRICT} or {@value #SCOPE_ID}.
+ */
Review Comment:
⚠️ **Missing `@since` on newly-public API.** This class was package-private;
it is now `public final`. All newly-public members need `@since 4.0.0` to match
the convention of their predecessor
`DefaultRepositorySystemSessionFactory.MAVEN_REPOSITORY_CREDENTIAL_SCOPE`
(which carries `@since 4.0.0`). Members that need the tag: class-level Javadoc,
`CREDENTIAL_SCOPE`, `SCOPE_ORIGIN`, `SCOPE_STRICT`, `SCOPE_ID`, `wrap()`,
`addOrigin()`, `originOf()`.
Example fix for `CREDENTIAL_SCOPE`:
```suggestion
/**
* User or system property selecting the credential scope: {@value
#SCOPE_ORIGIN} (default),
* {@value #SCOPE_STRICT} or {@value #SCOPE_ID}.
* @since 4.0.0
*/
public static final String CREDENTIAL_SCOPE =
"maven.repository.credentialScope";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
