slachiewicz opened a new pull request, #741:
URL: https://github.com/apache/maven-doxia-sitetools/pull/741

   The site renderer now builds a `ParserContext` (apache/maven-doxia#1125) for 
every document and passes it to the parser, so a parser gets the source and 
output location, the locale, the encodings and the string-valued template 
properties without injecting Maven components. Part of #736.
   
   The following points are not visible in the diff:
   
   - This needs a Doxia release with apache/maven-doxia#1125. The first commit 
points `doxiaVersion` at 2.2.1-SNAPSHOT as a placeholder, so CI fails until 
such a snapshot is published; replace that commit with the release version 
before merging.
   - `renderDocument(...)` calls the parser it looked up instead of 
`Doxia.parse(...)`, which only did the same lookup.
   - The properties leave out non-string values, such as the `MavenProject` the 
Site Plugin stores under `project`, and `inputEncoding` and `outputEncoding`, 
which the context has as charsets.
   - `render(...)` records its output directory in the `SiteRenderingContext`. 
A caller of `renderDocument(...)` that renders to a writer, such as `site:run`, 
leaves it unset and the parser sees no output directory.
   - Parser options stay empty; where they come from is an open question in 
#736.
   
   Verified: `mvn clean verify` on JDK 21 and Maven 3.9.16 against a local 
build of apache/maven-doxia#1125 → green.
   
   ---
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](https://www.apache.org/licenses/LICENSE-2.0)
   check one of the following:
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
   - [x] I hereby declare that I have filed an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to