slachiewicz commented on PR #1659:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/1659#issuecomment-6876700398

   Verified locally: the new IT fails on master 
(`go-offline-transitive-reactor-b:jar:1.0` could not be resolved) and passes on 
this branch under Maven 3.10.0-rc-1 and 4.0.0-rc-7, and `mvn -Prun-its verify` 
is green including `analyze-only`. Before merge:
   
   - Master already builds the request with `setRootArtifact` in the 
five-argument `resolveDependenciesForArtifact` since 
https://github.com/apache/maven-dependency-plugin/commit/8cc5d386c53b13ea51ebf1ca8dafd9b4ff13febc,
 so `GoOfflineMojo` can call that overload with the reactor filter and the 
`ResolverUtil` change can be dropped.
   - Please rebase onto master: the Windows failures are in copy, unpack and 
get tests on the old base, and master is green.
   - Tick one of the licence boxes in the description; the new 
license-declaration check needs it.
   - Update the description: a direct A→B→C reactor chain already works on 
master; the case this fixes is a reactor module reached through an external 
dependency, which is what the IT covers.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to