sharanggupta opened a new pull request, #14032: URL: https://github.com/apache/maven/pull/14032
When a recessive child matches a dominant child through `combine.id` or `combine.keys`, `DefaultXmlService.doMerge` merges it into the next dominant sibling with the same element name rather than into the matching one, so inherited configuration lands in the wrong element; `Xpp3DomUtils`, which this logic was ported from, merges into the match. The merged node could also replace the wrong sibling once recessive children had been added before it (`combine.children="append"`), and a second recessive child with the same id was dropped. Four of the five new `XmlNodeImplTest` cases fail without the change; the fifth guards the order-based merge of the remaining children. --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [ ] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
