elharo commented on code in PR #1438:
URL: https://github.com/apache/maven-scm/pull/1438#discussion_r4600347024


##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/main/java/org/apache/maven/scm/provider/git/repository/GitScmProviderRepository.java:
##########
@@ -346,8 +346,10 @@ private String parseUserInfo(RepositoryUrl repoUrl, String 
url) throws ScmExcept
             return url;
         }
         // extract user information, broken see SCM-907
-        int indexAt = url.lastIndexOf('@');
-        if (indexAt >= 0) {
+        // user info is only part of the authority, which ends at the first 
slash

Review Comment:
   This seems risky. Could we use one of the URI/URL classes to parse this 
instead and then pull it out if the authority?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to