[
http://jira.codehaus.org/browse/MENFORCER-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_127248
]
Benjamin Bentmann commented on MENFORCER-41:
--------------------------------------------
IMHO questionable additions. You are starting to use the Enforcer as a means to
validate an individual plugin configuration. Once we start that road, where
will it end?
Besides, ChangesFileExists is not really reusable as is. You have hard-coded
the path to the changes.xml but different projects will use different
locations. Last but not least, the existing rule RequireFilesExist can already
supercede this rule.
As for ChangesFileHasPomVersion: If there is really need for this validation
(To my knowledge, the report already fails if it cannot find the version), I
think it is best to move this directly into the maven-changes-plugin. The
Changes plugin knows pretty well how to parse its changes.xml. Duplicating the
parser code in the Enforcer would require an Enforcer update once the Changes
plugin introduces a new format, i.e. couples their release cycles. This does
not really look right neither.
> Enforcer rules for ChangesFileExists and ChangesFileHasPomVersion
> -----------------------------------------------------------------
>
> Key: MENFORCER-41
> URL: http://jira.codehaus.org/browse/MENFORCER-41
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Components: Standard Rules
> Reporter: Ben Lidgey
> Assignee: Brian Fox
> Attachments: MavenEnforcerChangesRules.zip
>
>
> New code to implement two rules:
> * ChangesFileExists -- checks there is a src/changes/changes.xml file
> * ChangesFileHasPomVersion -- checks the changes.xml has an entry with a
> version matching the current version in the pom.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
