[ 
http://jira.codehaus.org/browse/MIDEA-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_128078
 ] 

gotama commented on MIDEA-102:
------------------------------


Dennis, the patch you applied is highly unnecessarily complex. Take a look at 
the patch that Roman lists above. This is the one that should be applied. Its 3 
times smaller and easy to follow. If Roman's patch does not work, please 
explain why your patch works better.

However, Daniel, I have tested both Roman's patch and Dennis' patch, and they 
both work. I did not pull the snapshot though, I complied the patches myself. 
You may want to delete the 
.m2\repository\org\apache\maven\plugins\maven-idea-plugin directory to ensure 
you are in fact using the 2.2-SNAPSHOT. If it still does not work, please 
elaborate using the test pom's below.

Example:

      <module filepath="$PROJECT_DIR$/parent.iml"/>
      <module filepath="$PROJECT_DIR$/../child/child.iml"/>

Is the result of running mvn idea:idea on:

c:\foo\parent\pom.xml

<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
    <modelVersion>4.0.0</modelVersion>
    <groupId>com.test</groupId>
    <artifactId>parent</artifactId>
    <name>stubhub.com</name>
    <packaging>pom</packaging>
    <version>3.0.6</version>
    <description>Parent POM</description>
    <inceptionYear>2008</inceptionYear>
    <modules>
        <module>../child</module>
    </modules>

</project>

c:\foo\child\pom.xml

<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
    <modelVersion>4.0.0</modelVersion>
    <parent>
        <groupId>com.test</groupId>
        <artifactId>parent</artifactId>
        <version>3.0.6</version>
    </parent>
    <artifactId>child</artifactId>
    <name>test</name>
    <packaging>pom</packaging>
    <version>3.0.6</version>
    <description>child of test</description>
    <inceptionYear>2008</inceptionYear>

</project>


So, again, lets throw Roman's patch in 2.2 and release this puppy. Nothing else 
is open for 2.2.

Thanks.


> Module filepath is generated incorrectly for sibling parent
> -----------------------------------------------------------
>
>                 Key: MIDEA-102
>                 URL: http://jira.codehaus.org/browse/MIDEA-102
>             Project: Maven 2.x IDEA Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1
>         Environment: $ mvn -v
> Maven version: 2.0.7
> Java version: 1.5.0_11
> OS name: "windows xp" version: "5.1" arch: "x86"
> cygwin
>            Reporter: Joern Huxhorn
>            Assignee: Dennis Lundberg
>             Fix For: 2.2
>
>         Attachments: maven-idea-plugin-MIDEA-102.patch
>
>
> I have a multi-module mvn project.
> When I do an mvn idea:clean idea:idea, the following ProjectModuleManager 
> snippet in the top level .ipr is generated:
> <component name="ProjectModuleManager"> 
>     <modules> 
>       <!-- module filepath="$$PROJECT_DIR$$/${pom.artifactId}.iml"/ -->  
>       <module filepath="$PROJECT_DIR$/gateway.iml"/>
>       <module 
> filepath="$PROJECT_DIR$/C:/dev/voca/gateway/domain/gateway-domain.iml"/>
>       <module 
> filepath="$PROJECT_DIR$/C:/dev/voca/gateway/instruction-store/gateway-instruction-store.iml"/>
>       <module 
> filepath="$PROJECT_DIR$/C:/dev/voca/gateway/parser/gateway-parser.iml"/>
>       <module 
> filepath="$PROJECT_DIR$/C:/dev/voca/gateway/psrgeneration/gateway-psr-generation.iml"/>
>       <module 
> filepath="$PROJECT_DIR$/C:/dev/voca/gateway/output/gateway-output.iml"/>
>       <module 
> filepath="$PROJECT_DIR$/C:/dev/voca/gateway/destination-resolver/gateway-destination-resolver.iml"/>
>       <module 
> filepath="$PROJECT_DIR$/C:/dev/voca/gateway/choreography/gateway-choreography.iml"/>
>       <module 
> filepath="$PROJECT_DIR$/C:/dev/voca/gateway/presentation/gateway-presentation.iml"/>
>       <module 
> filepath="$PROJECT_DIR$/C:/dev/voca/gateway/assembly/gateway-assembly.iml"/>
>     </modules> 
>   </component>
> The $PROJECT_DIR in this case is C:/dev/voca/gateway/.
> But this path is being appended in a hard-coded fashion after the 
> $PROJECT_DIR entry.
> The symptom in Intellij is the following error message:
> Cannot load module: File 
> C:\dev\voca\gateway\C:\dev\voca\gateway\domain\gateway-domain.iml does not 
> exist
> Would you like to remove the module from the project?
> The workaround is to delete the extra appended file path from each module 
> entry in the above mentioned snippet.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to