[
http://jira.codehaus.org/browse/MERCURY-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=157474#action_157474
]
Gilles Scokart commented on MERCURY-48:
---------------------------------------
Cool !
Just Two comments.
1. From the tasks, it seems you are tighly coupled to maven repository (and
even maven settings file). Into your config, I think you should better ask the
developer to specify somehow that he want to use a maven repository (can be in
some tag name, in attribute name or value, wathever). It will also give clear
hook where to plug other type of repository (same from the settings, I guess)
2. With your API, the build will have to reexecute 2 resolution (one per
scope). I didn't looked into the source yet, but even if you can cache things,
I asume they will be quiet a lot of things done twice (scaning cache, parsing
pom, resolving some conflicts, etc...). One approach to avoid that is to first
make a resolve of multiple scope, and store the result in a resolutionId
reference, then use 'merc:path' task (or data types) that reference this
resolution.
An other aproach might be to allow to specify multiple pathId - scope as
sub-tag of your merc:resolve.
> Document and vet the design
> ---------------------------
>
> Key: MERCURY-48
> URL: http://jira.codehaus.org/browse/MERCURY-48
> Project: Mercury
> Issue Type: Sub-task
> Components: Ant tasks
> Reporter: Oleg Gusakov
> Assignee: Oleg Gusakov
> Original Estimate: 2 days
> Remaining Estimate: 2 days
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
