[ 
http://jira.codehaus.org/browse/MNG-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Torben S. Giesselmann updated MNG-3641:
---------------------------------------

    Attachment: MNG-3641-maven-project.patch

This patch will have Maven print a warning if a profile which should have been 
explicitely activated has in fact not been activated.

It's just a warning message, therefore I didn't write a test case. But just out 
of curiosity: how _would_ I test whether a warning with a specific message was 
logged or not? Is there a pattern for that?

> Lack of error checks on profiles
> --------------------------------
>
>                 Key: MNG-3641
>                 URL: http://jira.codehaus.org/browse/MNG-3641
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Profiles
>    Affects Versions: 2.0.9
>            Reporter: Kohsuke Kawaguchi
>             Fix For: 2.0.11
>
>         Attachments: MNG-3641-maven-project.patch
>
>
> DefaultProfileManager performs no error checks on the profile IDs So If I 
> specify bogus profile IDs from plugins (like {{mvn -P no-such-profile}}), 
> Maven doesn't complain, and it just runs as if nothing was specified. This is 
> very error prone.
> Also, I've seen some documentation that says deactivating a profile is "-P 
> !profile". As far as I can tell from the code, this is wrong, but because of 
> the lack of error check, such usage just gets ignored, and the user is left 
> confused as to why the profile isn't deactivated.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to