[
http://jira.codehaus.org/browse/MJAVADOC-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=172578#action_172578
]
Benjamin Bentmann commented on MJAVADOC-228:
--------------------------------------------
Looks fine to me. Just a few notes:
- {...@requiresdependencyresolution runtime}} seems unnecessary, the plugin
doesn't query project dependencies
- The mojo parameter {{enabled}} should probably be renamed to {{skip}} for
consistency with some other Maven plugins
- A common base class for the two mojos could help to reduce some code
redudancy like common parameters or the logic to skip unsupported artifact types
I'm awaiting the confirmation of your CLA record before importing this to the
sandbox.
> Please add support for signing javadoc jar files.
> -------------------------------------------------
>
> Key: MJAVADOC-228
> URL: http://jira.codehaus.org/browse/MJAVADOC-228
> Project: Maven 2.x Javadoc Plugin
> Issue Type: Wish
> Affects Versions: 2.5
> Environment: Maven version: 2.0.10
> Java version: 1.5.0_17
> OS name: "linux" version: "2.6.29" arch: "i386" Family: "unix"
> Reporter: Christian Schulte
> Attachments: maven-jarsigner-plugin.zip
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
