[
http://jira.codehaus.org/browse/MSITE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=195914#action_195914
]
Dennis Lundberg commented on MSITE-431:
---------------------------------------
Let me see if I understand this correctly.
"[FATAL] ..." is the message of the ProjectBuildingException that is thrown by
DefaultModelBuilder
SiteTool simply outputs this message as part of its exception handling, that
looks like this
{code}
catch ( ProjectBuildingException e )
{
getLogger().info( "Unable to load parent project from a relative path: " +
e.getMessage() );
}
{code}
making it look like there are two logging statements, when there is in fact
only one.
SiteTool is not handling errors correctly, which is the reason why the catch
block above is being executed.
Benjamin's commit in r829037 fixes this bad behavior in SiteTool, making sure
that the logging message "Unable to load parent project from a relative path"
isn't shown any more for this case.
> Rendering the site produces a Fatal error message if the parent pom isn't in
> the parent directory
> -------------------------------------------------------------------------------------------------
>
> Key: MSITE-431
> URL: http://jira.codehaus.org/browse/MSITE-431
> Project: Maven 2.x Site Plugin
> Issue Type: Improvement
> Affects Versions: 2.0.1
> Reporter: Niall Pemberton
> Priority: Minor
> Attachments: test-project.zip, warn-if-parent-pom-notfound.patch
>
>
> Apache Commons's parent pom[1] used by the 30+ commons components[2] is not
> in the parent directory. With maven 2.2.1 this just produces an [INFO]
> message saying "Unable to load parent project from a relative path". With
> maven 3 (built today from subversion) there is now also a [FATAL] message in
> the output (the build doesn't fail - but seeing [FATAL] in the output doesn't
> look good):
> * [INFO] --- maven-site-plugin:2.0.1:site (default-site) @ module-a ---
> * [INFO] Unable to load parent project from a relative path: 1 problem
> was encountered while building the effective model
> * [FATAL] Non-readable POM C:\svn\maven-test-proj\pom.xml:
> C:\svn\maven-test-proj\pom.xml (The system cannot find the file specified) @
> C:\svn\maven-test-proj\pom.xml for project at C:\svn\maven-test-proj\pom.xml
> I'm attaching a test project which demostrates this - need to first run "mvn
> install" on the parent-pom project and then "mvn site" on the module-a
> project to see the above output
> Also attaching a patch which catches FileNotFoundException and outputs a
> [WARNING] message instead of [FATAL] - not sure if this is the best solution,
> but in this circumstance its much better than seeing [FATAL} - even if the
> build doesn't fail.
> [1] http://svn.apache.org/repos/asf/commons/proper/commons-parent/
> [2] http://svn.apache.org/repos/asf/commons/proper/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
