[
http://jira.codehaus.org/browse/SUREFIRE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197086#action_197086
]
Brett Porter commented on SUREFIRE-555:
---------------------------------------
It doesn't have to be, but ideally it would all have the "licensed to
Apache..." header they all share. Since it is your own work you can certainly
do that. Would you mind resubmitting?
I would like some other changes and clarification:
- instead of "junitcore" is this basically a "junit 4.7+" feature? I got a bit
confused by the terminology
- the version parsing seems unusual - can we use a range instead ("[4.7,)")
- can you remove the .orig files from the patch?
- what is the purpose of the separated directory scanner?
Let me know if you need any more info on these.
> Support junit core for parallel running of tests
> ------------------------------------------------
>
> Key: SUREFIRE-555
> URL: http://jira.codehaus.org/browse/SUREFIRE-555
> Project: Maven Surefire
> Issue Type: New Feature
> Environment: All
> Reporter: Kristian Rosenvold
> Attachments: surefire.patch, surefirev2.patch
>
>
> The enclosed patch adds junitcore support to surefire. The patch requires
> junit 4.6 (the latest released version) to compile, but is only activated
> when running with the 4.7 snapshot or higher (due to some bugs in 4.6). The
> patch adds one extra setting to the surefire plugin. More details at
> http://incodewetrustinc.blogspot.com/
> The new plugin also requires an external library which can be found at
> http://github.com/krosenvold/configurable-parallel-computer/tree/master,
> which will be bumped to 1.0 when/if you decide to accept the patch. I am
> requesting that the junit project actually accept the features of the
> configurable-parallel-computer as a standard feature in junit 4.7, but that's
> not decided yet. I do not have a public maven repo that is hosting
> configurable-parallel-computer, but was hoping maybe you could publish it ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
