[
http://jira.codehaus.org/browse/WAGON-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=208759#action_208759
]
Brett Porter commented on WAGON-297:
------------------------------------
I'm a bit confused by it.
- the multiple levels of try/catch is a bit scary
- the checkOut call that fails with a TransferFailedException seems to be
called identically after calculating the missing directories. Am I misreading
it?
- it might be nice to have a block comment that explains what happens (are the
directories added in the local checkout, created, remotely, etc? Is it checking
out a new base directory higher up to create the directories?)
- also, you want to make sure you don't start creating directories within the
original supplied URL - wagon doesn't do that, only create those that it tries
to put within that.
Separately - is the test case one that is valid across all the providers? Maybe
it can be pushed up to the abstract class?
> Wagon SCM does not automatically create missing directories during deployment
> -----------------------------------------------------------------------------
>
> Key: WAGON-297
> URL: http://jira.codehaus.org/browse/WAGON-297
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-scm
> Affects Versions: 1.0-beta-6
> Reporter: Maria Odea Ching
> Attachments: WAGON-297.patch
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
