[
http://jira.codehaus.org/browse/MNG-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=213371#action_213371
]
Benjamin Bentmann edited comment on MNG-4583 at 3/10/10 10:18 AM:
------------------------------------------------------------------
bq. Would you please reopen this issue, so the misleading warning message can
be addressed for single-module builds?
No, I checked with some other Maven developers and we agreed that the warning
as produced in Maven 3 is fine. As I tried to explain before, a command line
like "mvn ... -P foo" does not mean the profile "foo" gets actually activated.
You as a user can only *request* to activate a profile, the actual activation
happens inside Maven by injecting the profile into the effective model and only
if such a profile exists. You can request to activate something that doesn't
exist but I don't agree that stating a non-existing profile has been activated
is an improvement to the warning message.
bq. Great, it's good to hear that's already been addressed.
Using the attached example project, I didn't observe any Maven version to
output the warning more than once during a multi-module build.
was (Author: bentmann):
bq. Would you please reopen this issue, so the misleading warning message
can be addressed for single-module builds?
No, I checked with some other Maven developers and we agreed that the warning
as produced in Maven 3 is fine. As I tried to explain before, a command line
like "mvn ... -P foo" does not mean the profile "foo" gets actually activated.
You as a user can only *request* to activate a profile, the actual activation
happens inside Maven by injecting the profile into the effective model and only
if such a profile exists. You can request to activate something that doesn't
exist but I don't agree that stating a non-existing profile has been activated
is an improvement to the warning message.
> warning printed when a pom does not use an activated profile is poorly worded
> and also should not be printed for multi-module builds
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MNG-4583
> URL: http://jira.codehaus.org/browse/MNG-4583
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.0.11, 2.2.1, 3.0-alpha-6
> Reporter: Ian Springer
> Assignee: Benjamin Bentmann
> Priority: Minor
> Fix For: 3.0-alpha-6
>
> Attachments: MNG-4583.zip
>
>
> This is a followup to http://jira.codehaus.org/browse/MNG-3641. Refer to that
> issue for the background.
> The current warning message is:
> "Profile with id: '" + explicitProfileId + "' has not been activated."
> I think this message is misleading, because the profile actually is activated
> - it's just not used at all in the pom being processed. I suggest changing
> the message to something like:
> "Profile with id '" + explicitProfileId + "' is activated, but this pom does
> not contain any usages of the profile."
> Also, I don't think it makes sense to print this warning at all in a
> multi-module build. In the large multi-module project I work on, we have a
> number of profiles that are only used in a handful of the 50 or so modules.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
