[ 
http://jira.codehaus.org/browse/MPLUGIN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=251599#action_251599
 ] 

Stanislav Ochotnicky edited comment on MPLUGIN-173 at 1/14/11 6:36 AM:
-----------------------------------------------------------------------

Previously jtidy had:
{code}
/**
* CharEncoding
* @see org.w3c.tidy.Configuration#CharEncoding
*/
public void setCharEncoding(int charencoding)
{code}

That used Configuration.XXX constants for character encodings

now there is:
{code}
/**                                                                             
                                                       
* <code>input-encoding</code> the character encoding used for input.
* @param encoding a valid java encoding name
*/             
public void setInputEncoding(String encoding)  
{code}

So the patch shouldn't change anything to what was used previously. I don't see 
how this could cause any problems. Plus just few lines below there already is 
"UTF-8" used to decode byte-stream. Though suggestions to make it better are 
welcome of course...

      was (Author: sochotnicky):
    Previously jtidy had:
/**
* CharEncoding
* @see org.w3c.tidy.Configuration#CharEncoding
*/
public void setCharEncoding(int charencoding)

That used Configuration.XXX constants for character encodings

now there is:
/**                                                                             
                                                       
* <code>input-encoding</code> the character encoding used for input.
* @param encoding a valid java encoding name
*/             
public void setInputEncoding(String encoding)  

So the patch shouldn't change anything to what was used previously. I don't see 
how this could cause any problems. Plus just few lines below there already is 
"UTF-8" used to decode byte-stream. Though suggestions to make it better are 
welcome of course...
  
> Start using net.sf.jtidy artifact with correct I/O encoding
> -----------------------------------------------------------
>
>                 Key: MPLUGIN-173
>                 URL: http://jira.codehaus.org/browse/MPLUGIN-173
>             Project: Maven 2.x Plugin Tools
>          Issue Type: Improvement
>          Components: API
>    Affects Versions: 2.6
>            Reporter: Stanislav Ochotnicky
>         Attachments: 0001-fix-for-new-jtidy.patch
>
>
> Current 2.6 version uses jtidy:jtidy artifact which is not being developed 
> anymore. net.sf.jtidy:jtidy artifact provides more features and is actively 
> developed. This patch replaces old artifact with new one and fixes -api to 
> not use deprecated functions for I/O encoding.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to