encoding property in maven plugin is never set correctly to charset property of
the checkstyle itself.
------------------------------------------------------------------------------------------------------
Key: MCHECKSTYLE-152
URL: http://jira.codehaus.org/browse/MCHECKSTYLE-152
Project: Maven 2.x Checkstyle Plugin
Issue Type: Bug
Affects Versions: 2.6, 2.5, 2.4
Environment: Windows x
Reporter: Svetlomira Manova
Attachments: DefaultCheckstyleExecutor.java, fix_CodeDifference.jpg
1. In the pom.xml i set property <encoding>:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.6</version>
<configuration>
<encoding>UTF-8</encoding>
</configuration>
</plugin>
2. When i run the checkstyle (mvn checkstyle:checkstyle) this property is not
set to "charset" attribute.
3. I noticed that this functionality works for version 2.2. However it does not
work for versions 2.4 and above. I think that this functionality does not work
after some refactoring is done and this functionality is moved in
org.apache.maven.plugin.checkstyle.DefaultCheckstyleExecutor -> "public
Configuration getConfiguration( CheckstyleExecutorRequest request )".
The problem is that in this method the developer tries to find the Checker
module and to set its "charset" attribute as a child of the "config" object.
However the "config" object it the Checker module itself.
Fix is simple - just take out adding of "charset" attribute value from the for
cycle.
I will attach the class with the new code and difference between the new and
old code.
I hope this bug can be fixed soon.
Thanks!
Best regards,
Svetlomira
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
