[
https://jira.codehaus.org/browse/MSHADE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=272051#comment-272051
]
ant elder commented on MSHADE-88:
---------------------------------
No, i didn't know about the run-its profile.
Ok the reason the dep-reduced-pom test fails is because its not testing with
promoteTransitiveDependencies set to true. Adding the line
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
to the its shade plugin configuration gets the test working. I'm not familiar
enough with the integration tests to know if its ok to make that change to the
dep-reduced-pom or if there needs to be a new test created for this.
> Pom type dependencies are incorrectly included in dependency reduced pom
> ------------------------------------------------------------------------
>
> Key: MSHADE-88
> URL: https://jira.codehaus.org/browse/MSHADE-88
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: ant elder
> Assignee: Benson Margulies
> Attachments: drpFix.txt, MSHADE-88-2.patch
>
>
> When shading with promoteTransitiveDependencies and
> createDependencyReducedPom set to true and using dependencies with a type of
> pom then the dependency reduced pom still includes the pom type dependencies,
> this is incorrect because the dependencies of the pom type dependency have
> already been included in the shaded artifact.
> The attached patch (based on trunk) fixes this by not including pom type
> dependencies to the dependency reduced pom. There are no existing tests for
> dependency reduced pom's or with pom type dependencies but this patch code
> does match what is already done for pom type dependencies in the ShadeMojo
> execute method at line 409.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
