[ 
https://jira.codehaus.org/browse/MWAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=279112#comment-279112
 ] 

Joerg Schaible commented on MWAR-260:
-------------------------------------

OK, it seems you have a slightly different model in mind. I assume now that a 
war-overlay project from your proposal generates a war file with a jar file 
extension, that is only used as an overlay in a real war project.

We have actually a different approach. We assemble in our main web application 
also several other (overlay) web applications i.e. small web applications 
(modules) that can be used also on their own. Additionally our main web 
application might be customized in a project and is used there as overlay. Any 
of those web applications are standard Maven projects producing a jar as main 
artifact that is also included in the attached web application. As result we 
have at any time a web application (individual modules, main web application or 
the customized one) that can be deployed on its own or that can be used again 
as overlay without loosing the dependency information.

bq. C depends on B and B depends on A then surely both B and A should be 
overlaid on C?

No, not in our model. If B excludes or overwrites some web resources of A, you 
want the B version in C. You don't want to have the changes made in B clobbered 
(or added) by resources from A in C again. Building C you should not really 
have to know that A exists and you may have to take care for something. 
However, this case cannot happen in your model, since you use only overlay-wars 
for overlays.

> Patch to provide new war-overlay type
> -------------------------------------
>
>                 Key: MWAR-260
>                 URL: https://jira.codehaus.org/browse/MWAR-260
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>          Components: overlay
>    Affects Versions: 2.1.1
>            Reporter: Alex Clarke
>
> There are a number of bugs raised around support for WAR overlays:
> MWAR-73 - war overlay mechanism does not work for classes
> MWAR-253 - Inherit dependencies from a WAR type dependency when it is 
> overlayed.
> MWAR-194 - Warn when inconsistent jar versions are detected during overlay
> MWAR-220 - dependencyManagement && overlay + transitive dependency = multiple 
> versions of same dependency in WEB-INF/lib
> MWAR-33 - jars with differents versions can be in WEB-INF/lib with war as 
> dependencies
> Most of these relate to the fact that overlays are not treated as normal 
> maven dependencies.
> The code in https://github.com/SciSysUK/maven-plugins/tree/waroverlay 
> introduces a new packaging type of "war-overlay", that works in the following 
> way:
>     - The primary artifact is a jar containing the classes from the overlay
>     - Another artifact is attached containing the web content
>     - A dependency on a war-overlay will automatically pull both artifacts 
> into the packaged war
> To use the new type all you need to do is declare 
> <extensions>true</extensions> on the maven-war-plugin. There is an 
> integration test example here: 
> https://github.com/SciSysUK/maven-plugins/tree/waroverlay/maven-war-plugin/src/it/war-overlay.
>  
> If someone could review the code I could create a patch and update the site 
> documentation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to