[ 
https://jira.codehaus.org/browse/MDEP-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=279134#comment-279134
 ] 

Anthony Whitford commented on MDEP-306:
---------------------------------------

I think the problem is this code found in 
[DependencyUtil.java|http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-dependency-plugin/src/main/java/org/apache/maven/plugin/dependency/utils/DependencyUtil.java]:{code}
    //
    // clean up configuration string before it can be tokenized
    //
    public static String cleanToBeTokenizedString( String str )
    {
        String ret = "";
        if ( !StringUtils.isEmpty( str ) )
        {
            ret = StringUtils.join( StringUtils.split( str ), "," );
        }

        return ret;
    }
{code}  I believe the split needs a separator specified (comma) otherwise it 
splits on whitespace:{code}
    //
    // clean up configuration string before it can be tokenized
    //
    public static String cleanToBeTokenizedString( String str )
    {
        String ret = "";
        if ( !StringUtils.isEmpty( str ) )
        {
            ret = StringUtils.join( StringUtils.split( str, "," ), "," );
        }

        return ret;
    }
{code}
See 
[StringUtils.java|http://plexus.codehaus.org/plexus-utils/apidocs/org/codehaus/plexus/util/StringUtils.html#split(java.lang.String,
 java.lang.String)] for more information.

> 2.2 unpack does not handle space in includes
> --------------------------------------------
>
>                 Key: MDEP-306
>                 URL: https://jira.codehaus.org/browse/MDEP-306
>             Project: Maven 2.x Dependency Plugin
>          Issue Type: Bug
>          Components: unpack
>    Affects Versions: 2.2
>         Environment: Windows XP, Java 6
>            Reporter: Anthony Whitford
>            Assignee: Brian Fox
>            Priority: Critical
>
> Upgrading to 2.2 broke my build and I traced the root cause to the fact that 
> I am calling unpack against a zip file and my includes specifies a filename 
> pattern with a space in the directory name.  This works fine if I roll back 
> to version 2.1, but 2.2 doesn't do anything (presumably nothing is matching 
> the includes spec).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to