[ 
https://jira.codehaus.org/browse/MWAR-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=282158#comment-282158
 ] 

Nicolas Marcotte commented on MWAR-81:
--------------------------------------

I will implements your suggestion later this week, or in the beginning the next 
week, thank you for the feedback !!!

By the way the negation is not currently applicable on the regex so the options 
will be standard,negatableStandard and regex

I did not submit negatable RegExes as it introduce a lot's of edges cases, and 
I do not want to figure them all .... Example: how do you handle that an 
exclusion expression like that :
{code:xml}
 <packagingMatchingStrategy>negatableRegexp</packagingMatchingStrategy>
 <packagingExclude>!(?sm)(?!struts)[0-9]+.*\.jar,.*\.jar</packagingExclude>
{code}

> Request enhancement to pattern matching for 
> packagingIncludes/packagingExcludes functionality (regular expressions?)
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: MWAR-81
>                 URL: https://jira.codehaus.org/browse/MWAR-81
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Wish
>         Environment: n/a
>            Reporter: Bryan Loofbourrow
>            Priority: Minor
>         Attachments: maven-war-plugin-2.1.1-NM.patch
>
>
> The Maven War Plugin currently permits choosing what files will wind up in 
> the .war. It does this via two parameters, warSourceIncludes, and 
> warSourceExcludes.  The rule appears to be that the includes are computed, 
> and a list of matches made, then that list is run against the excludes, and 
> any matches taken out of the include list.
> The only wildcards that appear to be supported are *, **, and ?.
> That doesn't work well if you are packaging wars in ears, and therefore want 
> to exclude all jars from the war, except for one or two that have to be in 
> the war in order to run properly.  "Exclude all but foo.jar and bar.jar" just 
> doesn't translate well to "here's your simple include template, here's your 
> simple exclude template" representation, at least with current wildcards.
> So this is a wish specifically for something to address the "exclude all but 
> x, y, and z" need for war source includes/excludes, and a suggestion that it 
> might be best to deprecate the warSourceIncludes/warSourceExcludes approach 
> in favor of a single parameter that supports regular expressions instead.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to