Guangtai Liang created DOXIA-464:
------------------------------------

             Summary: An incomplete fix for the resource leak bugs in 
XdocBookRenderer.java
                 Key: DOXIA-464
                 URL: https://jira.codehaus.org/browse/DOXIA-464
             Project: Maven Doxia
          Issue Type: Bug
            Reporter: Guangtai Liang
            Priority: Critical


The fix revision 1003021 was aimed to remove resource leak bugs on the 
SectionXdocBookSink  object "sink " (created in line 409) in the method 
"renderSection"of the file 
"/maven/doxia/doxia/trunk/doxia-book/src/main/java/org/apache/maven/doxia/book/services/renderer/XdocBookRenderer.java"
 , but it is incomplete.

There are some problems: 
1. when the statements at lines 411-418 throw some exception, "sink" will be 
leaked. 

The best way to close such resource objects is putting such close operations 
for all resource objects in the finaly block of a try-catch-finally structure 
and then putting all other code in a try block.

The problem still exists in the head revision.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to