[
https://jira.codehaus.org/browse/MRELEASE-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=295528#comment-295528
]
Robert Scholte commented on MRELEASE-507:
-----------------------------------------
I think we can close this issue as 'cannot reproduce'.
Here are the phases which will be executed: the {{run-preparation-goals}} is
executed before {{scm-tag}}
{code:xml}
<preparePhases>
<phase>check-poms</phase>
<phase>scm-check-modifications</phase>
<phase>check-dependency-snapshots</phase>
<phase>create-backup-poms</phase>
<phase>map-release-versions</phase>
<phase>input-variables</phase>
<phase>map-development-versions</phase>
<phase>rewrite-poms-for-release</phase>
<phase>generate-release-poms</phase>
<phase>run-preparation-goals</phase>
<phase>scm-commit-release</phase>
<phase>scm-tag</phase>
<phase>rewrite-poms-for-development</phase>
<phase>remove-release-poms</phase>
<phase>run-completion-goals</phase>
<phase>scm-commit-development</phase>
<phase>end-release</phase>
</preparePhases>
{code}
@Paul: you've already created an issue for adding scm:validate, but that
requires that every scm-provider has implemented it. This has quite an impact,
but it would indeed be an improvement.
And the tests aren't execute because of the {{site}} (actually site-deploy)
goal, but because of the deploy-goal during {{release:perform}}
> Execute tests before tagging
> ----------------------------
>
> Key: MRELEASE-507
> URL: https://jira.codehaus.org/browse/MRELEASE-507
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Components: prepare
> Affects Versions: 2.0-beta-9
> Reporter: Paul Benedict
>
> Preparing a release waits to execute tests until after the tag. If the
> tagging succeeds but the tests fail, the commit created a tag with failing
> tests, and the build fails altogether. I recommend the test phase should run
> before the tag... yes, in addition (or as a replacement) after the tagging
> phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
