[ 
https://jira.codehaus.org/browse/MNG-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=295596#comment-295596
 ] 

John Patrick commented on MNG-5267:
-----------------------------------

Additional submit needed 
https://github.com/nhojpatrick/maven-3/commit/433d908014304514380807b89c48ba2fe38f3b5a
 to handle ProjectSorter duplication check.
                
> False positive as DuplicateProjectException doesn't check project absolute 
> path
> -------------------------------------------------------------------------------
>
>                 Key: MNG-5267
>                 URL: https://jira.codehaus.org/browse/MNG-5267
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Plugins and Lifecycle
>    Affects Versions: 3.0.4
>         Environment: loki:~ john$ mvn -version
> Apache Maven 3.0.4 (r1232337; 2012-01-17 08:44:56+0000)
> Maven home: /opt/local/share/java/maven3
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
> Default locale: en_US, platform encoding: MacRoman
> OS name: "mac os x", version: "10.6.8", arch: "x86_64", family: "mac"
> loki:~ john$ java -version
> java version "1.6.0_29"
> Java(TM) SE Runtime Environment (build 1.6.0_29-b11-402-10M3527)
> Java HotSpot(TM) 64-Bit Server VM (build 20.4-b02-402, mixed mode)
> loki:~ john$ 
>            Reporter: John Patrick
>         Attachments: DefaultMaven.java.patch, exact-same-module.output.log, 
> exact-same-module.zip
>
>
> I'm getting false positive DuplicateProjectException being thrown, when 
> modules refer to the exact same project, i.e. pom absolute path is the same.
> Parent Pom
> -Sub Project One Pom
> -Sub Project Two Pom
> -Jar
> For ease of building individual sub components both Sub Project One and Two 
> refer to jar as being a module. I realize that having two pom's refering to 
> the same artifact as a module isn't the best solutions.
> But a simple change to when the Exception is thrown would remove this false 
> positive. In the exception is outputs both pom locations and they are exactly 
> the same absolute path.
> I've also forked on github.
> https://github.com/nhojpatrick/maven-3/commit/8e8c512d9535c58808fe1c4f58349313bbc3a887

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to