[
https://jira.codehaus.org/browse/MRELEASE-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=315682#comment-315682
]
Darryl L. Miles edited comment on MRELEASE-780 at 12/14/12 3:18 AM:
--------------------------------------------------------------------
Can everyone with an interest in this ticket declare their SCM provider type ?
svn ? git ? they work differently and the original code has an SVN bias.
I see Michael Wenig only references SVN so I take it to be the provider.
Also that if an SCM provider allows modification of a tag (as a feature of that
system) then if users of that SCM provider need to enforce a 'can not change
tag revision policy' it should always be enforced by the server. You should
treat this as a feature of the SCM provider you need to disable for your use
case. This is just stated to reinforce whose responsibility it is to enforce
such a policy. This has no effect on making the Maven release plugin better
i.e. while I may not fully understand the nature of what is being explained
(because I have yet to sit down and repeat the sequence and examine the
behaviour described first hand).
I think this bug is a duplicate of other bug numbers reporting the same matter.
The current workflow inside maven-release-plugin is:
maven-release-manager/src/main/components-fragment.xml:
<phase>rewrite-poms-for-branch</phase><!-- edit of pom.xml to change version
number in working copy -->
<phase>scm-commit-branch</phase><!-- commit the pom.xml change in the current
location -->
<phase>scm-branch</phase><!-- create a branch -->
But I propose there should be:
<phase>rewrite-poms-for-branch</phase><!-- edit of pom.xml to change version
number in working copy -->
<phase>scm-branch-prepare</phase><!-- create a branch, before any commit takes
place for this SCM that need operations in this order -->
<phase>scm-commit-branch</phase><!-- commit the pom.xml change in the current
location -->
<phase>scm-branch</phase><!-- create a branch; if we did not create it in
scm-branch-prepare for SCM that need operations in this order (or no-op for
some SCM providers) -->
I am slowly working on this idea for GIT SCM provider as I had presumed that
other SCM providers needed the sequence to be the other way around.
That being SVN needed it. However in light of this explanation what would the
repercussions of simply switching around the order of the 2 states:
scm-commit-branch AND scm-branch ? Without me working on adding a new state
'scm-branch-prepare'
So the really important question is exactly what SCM provider needs the phase
order as they are right now ?
was (Author: dlmiles):
Can everyone with an interest in this ticket declare their SCM provider
type ? svn ? git ? they work differently and the original code has an SVN
bias.
I see Michael Wenig only references SVN so I take it to be the provider.
Also that if an SCM provider allows modification of a tag (as a feature of that
system) then if users of that SCM provider need to enforce a 'can not change
tag revision policy' it should always be enforced by the server. You should
treat this as a feature of the SCM provider you need to disable for your use
case. This is just stated to reinforce whose responsibility it is to enforce
such a policy. This has no effect on making the Maven release plugin better
i.e. while I may not fully understand the nature of what is being explained
(because I have yet to sit down and repeat the sequence and examine the
behaviour described first hand).
I think this bug is a duplicate of other bug numbers reporting the same matter.
The current workflow inside maven-release-plugin is:
maven-release-manager/src/main/components-fragment.xml:
<phase>rewrite-poms-for-branch</phase><!-- edit of pom.xml to change version
number in working copy -->
<phase>scm-commit-branch</phase><!-- commit the pom.xml change in the current
location -->
<phase>scm-branch</phase><!-- create a branch -->
But I propose there should be:
<phase>rewrite-poms-for-branch</phase><!-- edit of pom.xml to change version
number in working copy -->
<phase>scm-branch-prepare</phase><!-- create a branch, before any commit takes
place for this SCM that need things in this order -->
<phase>scm-commit-branch</phase><!-- commit the pom.xml change in the current
location -->
<phase>scm-branch</phase><!-- create a branch (or no-op for some SCM providers)
-->
I am slowly working on this idea for GIT SCM provider as I had presumed that
other SCM providers needed the sequence to be the other way around.
That being SVN needed it. However in light of this explanation what would the
repercussions of simply switching around the order of the 2 states:
scm-commit-branch AND scm-branch ? Without me working on adding a new state
'scm-branch-prepare'
So the really important question is exactly what SCM provider needs the phase
order as they are right now ?
> Prevent Tag from additional commits
> ------------------------------------
>
> Key: MRELEASE-780
> URL: https://jira.codehaus.org/browse/MRELEASE-780
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Components: scm
> Affects Versions: 2.3.2
> Reporter: E
>
> If you create an release from the branch there should be no commits on the
> tag-folder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
