[ 
https://jira.codehaus.org/browse/SUREFIRE-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322102#comment-322102
 ] 

Jesse Glick commented on SUREFIRE-974:
--------------------------------------

If there is a bug in JUnit itself, I cannot find it:

{code}
System.err.println("surefire-junit4");
RunNotifier notifier = new RunNotifier();
notifier.addListener(new TextListener(System.err));
Request.aClass(Complex3Test.class).getRunner().run(notifier);
System.err.println("surefire-junit47");
JUnitCore core = new JUnitCore();
core.addListener(new TextListener(System.err));
System.err.println("failures: " + core.run(Request.classes(new Computer(), 
Complex3Test.class)).getFailureCount());
{code}
                
> Custom junit.framework.TestSuite subtypes ignored when excludedGroups defined
> -----------------------------------------------------------------------------
>
>                 Key: SUREFIRE-974
>                 URL: https://jira.codehaus.org/browse/SUREFIRE-974
>             Project: Maven Surefire
>          Issue Type: Bug
>    Affects Versions: 2.14
>            Reporter: Jesse Glick
>         Attachments: SUREFIRE-974.zip
>
>
> In Jenkins sources @ 919bab8, run:
> {{mvn -f test/pom.xml -Dtest=CoreJellyTest 
> -Dtest.excluded.groups=org.jvnet.hudson.test.FailsOnCloud test}}
> You will get errors from every test case in this suite. When 
> {{test.excluded.groups}} is not defined, it passes.
> This property just sets {{excludedGroups}} for the benefit of some unrelated 
> JUnit 4 tests in the same module which use {{@Category}}. But turning it on 
> apparently changes how JUnit 3 tests are run, too. The named suite has a 
> {{public static Test suite()}} method which creates a subclass of 
> {{TestSuite}} that overrides {{void run(TestResult)}}; when 
> {{excludedGroups}} is defined, a plain {{TestSuite}} is created which fails 
> to set the proper context for test cases and fails utterly.
> Refactoring this test suite to use JUnit 4 idioms is probably not an option 
> at the moment for compatibility reasons. Why is Surefire failing to correctly 
> run JUnit 3 tests just because groups are defined?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to