[ 
https://jira.codehaus.org/browse/SUREFIRE-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=324649#comment-324649
 ] 

Kristian Rosenvold edited comment on SUREFIRE-569 at 5/3/13 12:00 PM:
----------------------------------------------------------------------

Strictly speaking the filter expression should accept wildcards and 4-part 
specifications like for instance includes does on maven-shade-plugin; which 
would allow for specifications like G:\*:\*:test-jar
which would pick up all test-jars from a given group-id.

The artifact filtering could/should probably use maven-common-artifact-filters 
if it is to be extended any further; this module was extracted with filtering 
in mind.

I think the current patch is a nice starting point and I have applied it in 
c808eec805509f14160454829df8f496499f0f4e.

@Aslak; I appreciate you keeping the patch footprint moderate, it makes it 
easier to review and accept. On the other hand I think all the changes you 
describe should be done :) I would've ok'd all those changes and may choose do 
some of them myself !

Thanks for the patch!


                
      was (Author: krosenvold):
    Strictly speaking the filter expression should accept wildcards and 4-part 
specifications like for instance includes does on maven-shade-plugin; which 
would allow for specifications like G:*:*:test-jar
which would pick up all test-jars from a given group-id.

The artifact filtering could/should probably use maven-common-artifact-filters 
if it is to be extended any further; this module was extracted with filtering 
in mind.

I think the current patch is a nice starting point and I have applied it in 
c808eec805509f14160454829df8f496499f0f4e.

@Aslak; I appreciate you keeping the patch footprint moderate, it makes it 
easier to review and accept. On the other hand I think all the changes you 
describe should be done :) I would've ok'd all those changes and may choose do 
some of them myself !

Thanks for the patch!


                  
> There should be a way to run unit tests from a dependency jar.
> --------------------------------------------------------------
>
>                 Key: SUREFIRE-569
>                 URL: https://jira.codehaus.org/browse/SUREFIRE-569
>             Project: Maven Surefire
>          Issue Type: New Feature
>          Components: Maven Surefire Plugin
>            Reporter: Paul Gier
>            Assignee: Kristian Rosenvold
>             Fix For: 2.15
>
>         Attachments: SUREFIRE-569.patch
>
>
> In some cases it would be useful to have a set of tests that run with various 
> dependency configurations.  One way to accomplish this would be to have a 
> single project that contains the unit tests and generates a test jar.  
> Several test configuration projects could then consume the unit tests and run 
> them with different dependency sets.  The problem is that there is no easy 
> way to run tests in a dependency jar.  The surefire plugin should have a 
> configuration to allow me to run all or a set of unit tests contained in a 
> dependency jar.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to