[ 
https://jira.codehaus.org/browse/MINSTALL-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=334205#comment-334205
 ] 

Robert Scholte commented on MINSTALL-96:
----------------------------------------

You've just described a perfect example where you thought that skipping would 
be the best solution, but which would be the start of a chain of other 
adjustments.
So actually, the {{install}} phase was always correct: the plugin installed the 
artifact and the attachments. However, during {{deploy}} in some cases you 
don't want to upload the attachments. By trying to solve this issue, the 
closest you could get was an {{install-file}} hack. But the hack is not good 
enough so the hack needs to be hacked.
Instead, I'm willing to do the following: improve the {{deploy}} goal the a 
{{excludeClassifiedArtifacts}} (or something like that) where you can specify 
the classifiers (and/or extension?) of the attachments which should be excluded.
In conclusion: I still think that the {{install-file}} goal should not have the 
{{skip}} option.
                
> Skip option for install-file
> ----------------------------
>
>                 Key: MINSTALL-96
>                 URL: https://jira.codehaus.org/browse/MINSTALL-96
>             Project: Maven Install Plugin
>          Issue Type: Improvement
>          Components: install:install-file
>    Affects Versions: 2.4
>            Reporter: Tiemo Vorschütz
>         Attachments: InstallFileMojo.java.patch
>
>
> For my process it would be helpful to also introduce a skip option for 
> install:install-file to be able to disable install-file creation by setting a 
> pom property.
> This could be necessary if the build chain is designed by a parent pom and 
> should by simply modified inside the child pom.
> In my case all plugin definitions are outsourced to the parent pom file and 
> should only be set by properties by the developers to take care that 
> modifications to the build chain are inherited.
> I attached a patch to enable skipping also for install-file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to