[
https://jira.codehaus.org/browse/DOXIASITETOOLS-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338402#comment-338402
]
Herve Boutemy commented on DOXIASITETOOLS-87:
---------------------------------------------
seems like improvement has to be done in
[DefaultSiteRenderer.html#620|http://maven.apache.org/doxia/doxia-sitetools-archives/doxia-sitetools-1.3/doxia-site-renderer/xref/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.html#620]
{code:java} public SiteRenderingContext createContextForSkin( File skinFile,
Map<String, ?> attributes,
DecorationModel
decoration, String defaultWindowTitle,
Locale locale )
throws IOException
{
SiteRenderingContext context = new SiteRenderingContext();
ZipFile zipFile = getZipFile( skinFile );
try
{
if ( zipFile.getEntry( SKIN_TEMPLATE_LOCATION ) != null )
{
context.setTemplateName( SKIN_TEMPLATE_LOCATION );
context.setTemplateClassLoader( new URLClassLoader( new
URL[]{skinFile.toURI().toURL()} ) );
}
else
{
context.setTemplateName( DEFAULT_TEMPLATE );
context.setTemplateClassLoader( getClass().getClassLoader() );
context.setUsingDefaultTemplate( true );
}
}
finally
{
closeZipFile( zipFile );
}{code}
> inconsistent newlines between template from skin and content generated
> ----------------------------------------------------------------------
>
> Key: DOXIASITETOOLS-87
> URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-87
> Project: Maven Doxia Sitetools
> Issue Type: Bug
> Components: Site renderer
> Reporter: Herve Boutemy
>
> template from skin artifact is read with newline set from skin artifact
> builder
> then content is added into it with current newline, which can be different
> from artifact builder
> Template newline should be harmonized with current newline
> this causes MSITE-121 and requires hack in
> [maven-scm-publish-plugin|http://maven.apache.org/plugins/maven-scm-publish-plugin/]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
