[
https://jira.codehaus.org/browse/MCHECKSTYLE-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=342870#comment-342870
]
Arlo Louis O'Keeffe edited comment on MCHECKSTYLE-221 at 3/13/14 7:11 PM:
--------------------------------------------------------------------------
You are absolutely right. It is the correct value. Maven file patterns are
influenced by [ant FileSets|http://ant.apache.org/manual/Types/fileset.html]
and the first example explains it perfectly.
I just followed the trail of the includes property and believe that the \ can
be safely removed.
[DefaultCheckstyleExcecutor|http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.12/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java?view=markup#l557]
passes {{\*\*\/\*.java}} to
[org.codehaus.plexus.util.FileUtils.getFiles()|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/FileUtils.java#FileUtils.getFiles%28java.io.File%2Cjava.lang.String%2Cjava.lang.String%29]
which uses
[AbstractScanner.setIncludes|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/AbstractScanner.java#AbstractScanner.setIncludes%28java.lang.String%5B%5D%29].
There the pattern is converted to {{\*\*//\*.java}} (in the case of a unix
system). This pattern is passed to
[MatchPatterns.from()|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/MatchPatterns.java#MatchPatterns.from%28java.lang.String%5B%5D%29]
and ends up in a Tokenizer that uses {{/}} as a separator. The Tokenizer will
ignore the duplicate {{/}} and therefore the \ can be removed.
was (Author: arlol):
You are absolutely right. It is the correct value. Maven file patterns are
influenced by [ant FileSets|http://ant.apache.org/manual/Types/fileset.html]
and the first example explains it perfectly.
I just followed the trail of the includes property and believe that the \ can
be safely removed.
[DefaultCheckstyleExcecutor|http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.12/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java?view=markup#l557]
passes {{\*\*\/\*.java}} to
[org.codehaus.plexus.util.FileUtils.getFiles()|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/FileUtils.java#FileUtils.getFiles%28java.io.File%2Cjava.lang.String%2Cjava.lang.String%29]
which uses
[AbstractScanner.setIncludes|http://plexus.codehaus.org/plexus-utils/apidocs/index.html].
There the pattern is converted to {{\*\*//\*.java}} (in the case of a unix
system). This pattern is passed to
[MatchPatterns.from()|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/MatchPatterns.java#MatchPatterns.from%28java.lang.String%5B%5D%29]
and ends up in a Tokenizer that uses {{/}} as a separator. The Tokenizer will
ignore the duplicate {{/}} and therefore the \ can be removed.
> ResourceIncludes default value is wrong
> ---------------------------------------
>
> Key: MCHECKSTYLE-221
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-221
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Affects Versions: 2.11
> Reporter: Arlo Louis O'Keeffe
> Assignee: Dennis Lundberg
> Priority: Minor
> Fix For: 2.12
>
>
> The default value for resourceIncludes is supposed to be \*\*\/\*.properties
> but in fact it is \*\*/\*.properties.
> You can verify in the generated maven site:
> https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#resourceIncludes
> An easy workaround is to simply define resourceIncludes yourself.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
