[
https://jira.codehaus.org/browse/MCHECKSTYLE-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=350807#comment-350807
]
Herve Boutemy commented on MCHECKSTYLE-244:
-------------------------------------------
I'm ok with the problem on LicenseResourceManager being not threadsafe: this
part is a duplicate of MCHECKSTYLE-230
for DefaultCheckstyleRssGenerator, AFAIK, it only uses VelocityCompoennt, which
is threadsafe: so I don't see any issue
can you confirm?
> LicenseResourceManager component is not thread safe and causes parallel build
> failures
> --------------------------------------------------------------------------------------
>
> Key: MCHECKSTYLE-244
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-244
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Affects Versions: 2.12, 2.12.1
> Reporter: Konstantin Pokrovsky
>
> *LicenseResouceManager* component does not specify instantiation strategy. By
> default plexus uses singleton strategey which leads to
> *ConcurrentModificationException* in parallel maven builds.
> Example: when two *DefaultCheckstyleExecutors* try to use one licence
> manager: one calls *addSearchPath* on *FileResourceLoader* while the other
> one iterating over paths in *getResource* on the same *FileResourceLoader* .
> [MCHECKSTYLE-238|https://jira.codehaus.org/browse/MCHECKSTYLE-238] and
> [MCHECKSTYLE-230|https://jira.codehaus.org/browse/MCHECKSTYLE-230] are
> exactly about this situation. Right now the plugin for some reason is marked
> as thread safe although it definetly produces exceptions in parallel
> multimodule builds.
> *DefaultCheckstyleRssGenerator* is a point of attention becaue it is also
> singleton instantiated.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
