[ 
https://jira.codehaus.org/browse/MRELEASE-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=353287#comment-353287
 ] 

Alexander Klimetschek edited comment on MRELEASE-875 at 9/26/14 2:13 PM:
-------------------------------------------------------------------------

How would you recommend to bring in maven-scm 1.9.2 (you are talking about 
maven-scm, right)? AFAICS, a normal maven pom setup would just depend on the 
maven-release-plugin, which itself only depends on maven-scm-api (1.9 in the 
latest released maven-release-plugin 2.5 from January). Not sure how maven-scm 
is pulled in normally.

Would you add it as dependency to the maven-release-plugin like this (in e.g. a 
parent pom)?
{code:xml}
<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-release-plugin</artifactId>
    <version>2.5</version>
    <dependencies>
        <dependency>
            <groupId>org.apache.maven.scm</groupId>
            <artifactId>maven-scm</artifactId>
            <version>1.9.2</version>
        </dependency>
    </dependencies>
    <configuration>
        <!-- configs ... -->
    </configuration>
</plugin>
{code}


was (Author: aklimets):
How would you recommend to bring in maven-scm 1.9.2 (you are talking about 
maven-scm, right)? AFAICS, a normal maven pom setup would just depend on the 
maven-release-plugin, which itself only depends on maven-scm-api (1.9 in the 
latest released maven-release-plugin 2.5 from January). Not sure how maven-scm 
is pulled in normally.

Would you add it as dependency to the maven-release-plugin like this (in e.g. a 
parent pom)?
{code}
<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-release-plugin</artifactId>
    <version>2.5</version>
    <dependencies>
        <dependency>
            <groupId>org.apache.maven.scm</groupId>
            <artifactId>maven-scm</artifactId>
            <version>1.9.2</version>
        </dependency>
    </dependencies>
    <configuration>
        <!-- configs ... -->
    </configuration>
</plugin>
{code}

> release:prepare does not commit pom.xml if not in the git root
> --------------------------------------------------------------
>
>                 Key: MRELEASE-875
>                 URL: https://jira.codehaus.org/browse/MRELEASE-875
>             Project: Maven Release Plugin
>          Issue Type: Bug
>          Components: prepare, scm
>    Affects Versions: 2.5
>         Environment: git 1.9.0
>            Reporter: john ten Den
>            Assignee: Benson Margulies
>             Fix For: 2.5.1
>
>
> When the project pom.xml is not in the Git project root (f.e. in the "src" 
> directory) the pom.xml not committed and pushed (before tagging)
> Commit of the pom.xml during release:prepare works fine if it is in the / 
> (root) of the git repository
> Using the pom.xml in a subdirectory worked well with version 2.4.2 using git 
> 1.7. 



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to