[
https://jira.codehaus.org/browse/SUREFIRE-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=359604#comment-359604
]
Michael Osipov commented on SUREFIRE-691:
-----------------------------------------
I won't push anything until you say so.
bq. I am not still sure this is worth to fix, because people may simply
upstream new site on the top of the old one without deleting and in that case
you may still see the old report page. We should prevent from opening new bugs.
It looks like the user needs faster build and thus #generateEmpty() instead of
#canGenerate(). What you think.
I do not fully agree. It is true that the old site might remain but it is gone
from the menu, unreachable without links. More over, {{canGenerate}} serves a
different purpose. I have added {{skipEmptyReport}} to many other reports (
e.g., MPIR, MPMD, etc.) in the last couple of weeks. The rationale is always
the same: if something isn't there, like no unit tests, there is no need to
generate an empty report. {{canGenerate}} only tests whether a report can be
generated at all, conditions met. Personally, I am confused by a report which
contains no information.
> Skip reports and menu link generation when it does not make sense (i.e: test
> results are missing)
> -------------------------------------------------------------------------------------------------
>
> Key: SUREFIRE-691
> URL: https://jira.codehaus.org/browse/SUREFIRE-691
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Surefire Report Plugin
> Affects Versions: 2.8
> Reporter: Marcin Kuthan
> Assignee: Michael Osipov
> Priority: Minor
> Attachments: screenshot.png, SUREFIRE-691.patch, SUREFIRE-691.patch
>
>
> Surefire report page and link in the menu are generated even if there is no
> tests. It also happens for submodules when -Daggregate=true is given.
> Another plugins which supports report aggregation (m-pmd-p, m-javadoc-p,
> m-jxr-p) don't generate link in the menu and empty report page when report
> does not make sense.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
