[ 
https://issues.apache.org/jira/browse/MESOS-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183537#comment-14183537
 ] 

Dominic Hamon commented on MESOS-1919:
--------------------------------------

this requires every callsite to check the family and get the right address, 
which is not the point of an abstraction. This may be ok for storage, but I'd 
rather the callsites interact with IP addresses without any notion of what 
family is used.

> Create IP address abstraction
> -----------------------------
>
>                 Key: MESOS-1919
>                 URL: https://issues.apache.org/jira/browse/MESOS-1919
>             Project: Mesos
>          Issue Type: Task
>          Components: libprocess
>            Reporter: Dominic Hamon
>            Assignee: Evelina Dumitrescu
>            Priority: Minor
>
> in the code many functions need only the ip address to be passed as a 
> parameter. I don't think it would be desirable to use a struct 
> SockaddrStorage (MESOS-1916).
> Consider using a {{std::vector<unsigned char>}} (see {{typedef 
> std::vector<unsigned char> IPAddressNumber;}} in the Chromium project)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to