[ https://issues.apache.org/jira/browse/MESOS-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14206972#comment-14206972 ]
Ian Downes commented on MESOS-1718: ----------------------------------- We currently add the first task's resources to the executor's resources when launching the executor. Is that sufficient? We could simply remove this extra allowance then, without requiring a transfer from task to executor. {noformat} // Tell the containerizer to launch the executor. // NOTE: We modify the ExecutorInfo to include the task's // resources when launching the executor so that the containerizer // has non-zero resources to work with when the executor has // no resources. This should be revisited after MESOS-600. ExecutorInfo executorInfo_ = executor->info; Resources resources = executorInfo_.resources(); resources += taskInfo.resources(); executorInfo_.mutable_resources()->CopyFrom(resources); {noformat} > Command executor can overcommit the slave. > ------------------------------------------ > > Key: MESOS-1718 > URL: https://issues.apache.org/jira/browse/MESOS-1718 > Project: Mesos > Issue Type: Bug > Components: slave > Reporter: Benjamin Mahler > Assignee: Ian Downes > > Currently we give a small amount of resources to the command executor, in > addition to resources used by the command task: > https://github.com/apache/mesos/blob/0.20.0-rc1/src/slave/slave.cpp#L2448 > {code: title=} > ExecutorInfo Slave::getExecutorInfo( > const FrameworkID& frameworkId, > const TaskInfo& task) > { > ... > // Add an allowance for the command executor. This does lead to a > // small overcommit of resources. > executor.mutable_resources()->MergeFrom( > Resources::parse( > "cpus:" + stringify(DEFAULT_EXECUTOR_CPUS) + ";" + > "mem:" + stringify(DEFAULT_EXECUTOR_MEM.megabytes())).get()); > ... > } > {code} > This leads to an overcommit of the slave. Ideally, for command tasks we can > "transfer" all of the task resources to the executor at the slave / isolation > level. -- This message was sent by Atlassian JIRA (v6.3.4#6332)