[ https://issues.apache.org/jira/browse/MESOS-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360200#comment-14360200 ]
Alexander Rojas commented on MESOS-2494: ---------------------------------------- https://reviews.apache.org/r/32034/ > Clang build broken with "expression result unused" warning > ---------------------------------------------------------- > > Key: MESOS-2494 > URL: https://issues.apache.org/jira/browse/MESOS-2494 > Project: Mesos > Issue Type: Bug > Reporter: Alexander Rojas > Assignee: Alexander Rojas > > Commit 8385bba added code which thoroughly compares protobuf messages, > however one of the changes looks like: > {code} > return left.task_id() == right.task_id(); // This semicolon shouldn't be > here. > left.state() == right.state() && > left.data() == right.data() && > left.message() == right.message() && > left.slave_id() == right.slave_id() && > left.timestamp() == right.timestamp() && > left.executor_id() == right.executor_id() && > left.healthy() == right.healthy() && > left.source() == right.source() && > left.reason() == right.reason() && > left.uuid() == right.uuid(); > {code} > which results to clang build's failing with "expression result unused." Not > to mention the given code has a bug in itself. -- This message was sent by Atlassian JIRA (v6.3.4#6332)