[
https://issues.apache.org/jira/browse/MESOS-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384790#comment-14384790
]
Aditi Dixit commented on MESOS-2565:
------------------------------------
Hi. I'd like to work on this as my first contribution to Mesos.
But I have a doubt about how the module name is set. I understand from
include/mesos/module.hpp that the variable name becomes the module name. But
shouldn't they be org_apache_mesos_TestHook instead of just TestHook ?
> Clean up style and comments in modules.
> ---------------------------------------
>
> Key: MESOS-2565
> URL: https://issues.apache.org/jira/browse/MESOS-2565
> Project: Mesos
> Issue Type: Improvement
> Components: modules
> Reporter: Alexander Rukletsov
> Priority: Minor
> Labels: easyfix, newbie
>
> We have some minor style issues in modules code. This ticket aims to clean
> them up.
> ----
> *{{s/template<>/template <>/}}*
> Affected files:
> include/mesos/module/authenticatee.hpp
> include/mesos/module/authenticator.hpp
> include/mesos/module/hook.hpp
> include/mesos/module/isolator.hpp
> src/examples/test_module.hpp
> *Move { } onto the previous line in Module c-tors*
> Affected files:
> include/mesos/module/authenticatee.hpp
> include/mesos/module/authenticator.hpp
> include/mesos/module/hook.hpp
> include/mesos/module/isolator.hpp
> src/examples/test_module.hpp
> *Misleading comments in test modules.*
> Module name is an exported symbol. Comments on module declaration should
> reflect this. Affected files:
> src/examples/test_anonymous_module.cpp
> src/examples/test_hook_module.cpp
> src/examples/test_isolator_module.cpp
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
