[
https://issues.apache.org/jira/browse/MESOS-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Schad updated MESOS-2673:
-------------------------------
Description:
The header include order for Mesos actually follows the Google Styleguide but
omits step 1 without mentioning this exception in the Mesos styleguide. This
proposal suggests to adapt to the include order explained in the Google
Styleguide i.e. include the direct headers first in the .cpp files implementing
them.
A gist of the proposal can be found here:
https://gist.github.com/joerg84/65cb9611d24b2e35b69b
The corresponding Review Board review can be found here:
https://reviews.apache.org/r/33646/
was:
Regarding the header include order the Mesos style actually follows the Google
Styleguide but omits step 1 without mentioning this exception in the Mesos
styleguide. This proposal suggests to adapt to the include order explained in
the Google Styleguide i.e. include the direct headers first in the .cpp files
implementing them.
A gist of the proposal can be found here:
https://gist.github.com/joerg84/65cb9611d24b2e35b69b
The corresponding Review Board review can be found here:
https://reviews.apache.org/r/33646/
> Follow Google Style Guide for header file include order completely.
> -------------------------------------------------------------------
>
> Key: MESOS-2673
> URL: https://issues.apache.org/jira/browse/MESOS-2673
> Project: Mesos
> Issue Type: Epic
> Reporter: Joerg Schad
> Assignee: Joerg Schad
>
> The header include order for Mesos actually follows the Google Styleguide but
> omits step 1 without mentioning this exception in the Mesos styleguide. This
> proposal suggests to adapt to the include order explained in the Google
> Styleguide i.e. include the direct headers first in the .cpp files
> implementing them.
> A gist of the proposal can be found here:
> https://gist.github.com/joerg84/65cb9611d24b2e35b69b
> The corresponding Review Board review can be found here:
> https://reviews.apache.org/r/33646/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
