[ 
https://issues.apache.org/jira/browse/MESOS-2664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592907#comment-14592907
 ] 

Michael Park commented on MESOS-2664:
-------------------------------------

Great idea! We could turn it on as a warning, but I'm not sure how effective 
that would be since they're likely going to fly by during {{make}}. (Unless 
there's a way to suppress {{make}} enough to clearly see the warnings but not 
all the other compile/link commands, etc).

If we were to turn it on as an error, we can either (1) not use {{default}} and 
spell out the missing cases explicitly, or (2) use something like {{#pragma GCC 
diagnostic ignored "-Wswitch-enum"}} to temporarily turn it off.

I've put together an experiment 
[here|https://github.com/mesosphere/mesos/tree/switch-enum] if you're 
interested in taking a look at what it might look like.

> Modernize the codebase to C++11
> -------------------------------
>
>                 Key: MESOS-2664
>                 URL: https://issues.apache.org/jira/browse/MESOS-2664
>             Project: Mesos
>          Issue Type: Epic
>          Components: technical debt
>            Reporter: Michael Park
>            Assignee: Michael Park
>              Labels: mesosphere
>
> Since [this 
> commit|https://github.com/apache/mesos/commit/0f5c78fad3423181f7227027eb42d162811514e7],
>  we officially require GCC-4.8+ and Clang-3.5+. This means that we now have 
> full C++11 support and therefore can start to modernize our codebase to be 
> more readable, safer and efficient!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to