[
https://issues.apache.org/jira/browse/MESOS-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723603#comment-14723603
]
haosdent commented on MESOS-3329:
---------------------------------
Hi, [~qiujian] You need find a committer as Shepherd to help you commit that.
And please mark this issue to reviewable. :-)
> Unused hashmap::existsValue functions have incomplete code paths
> ----------------------------------------------------------------
>
> Key: MESOS-3329
> URL: https://issues.apache.org/jira/browse/MESOS-3329
> Project: Mesos
> Issue Type: Bug
> Components: stout
> Reporter: Jan Schlicht
> Assignee: Jian Qiu
> Priority: Trivial
> Labels: easyfix, mesosphere
>
> `stout/hashmap.hpp` defines functions `hashmap::existsValue`. These return
> true if a certain value exists in the hashmap instance. The control flow of
> these functions doesn't cover the case that the value is not found, which
> should result in false. Right now the result in this case is undefined.
> As the `existsValue` functions are never called this doesn't result in a
> compile error atm.
> Possible solutions:
> 1) Add `return false`
> 2) Remove function
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
