[ https://issues.apache.org/jira/browse/MESOS-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734379#comment-14734379 ]
Qian Zhang commented on MESOS-3338: ----------------------------------- Once a resource is dynamically reserved for a role, it will be considered as available resources for that role, but not for any other roles. And for this bug, I am not sure we should consider dynamic reserved resource as slave's used resource, my understanding is, slave's used resource is increased when launching task, and decreased when task is terminated, it should not have direct relationship with dynamic reservation. > Dynamic reservations are not counted as used resources in the master > -------------------------------------------------------------------- > > Key: MESOS-3338 > URL: https://issues.apache.org/jira/browse/MESOS-3338 > Project: Mesos > Issue Type: Bug > Components: allocation, master > Reporter: Alexander Rukletsov > Assignee: Guangya Liu > Priority: Minor > > Dynamically reserved resources should be considered used or allocated and > hence reflected in Mesos bookkeeping structures and {{state.json}}. > I expanded the {{ReservationTest.ReserveThenUnreserve}} test with the > following section: > {code} > // Check that the Master counts the reservation as a used resource. > { > Future<process::http::Response> response = > process::http::get(master.get(), "state.json"); > AWAIT_READY(response); > Try<JSON::Object> parse = JSON::parse<JSON::Object>(response.get().body); > ASSERT_SOME(parse); > Result<JSON::Number> cpus = > parse.get().find<JSON::Number>("slaves[0].used_resources.cpus"); > ASSERT_SOME_EQ(JSON::Number(1), cpus); > } > {code} > and got > {noformat} > ../../../src/tests/reservation_tests.cpp:168: Failure > Value of: (cpus).get() > Actual: 0 > Expected: JSON::Number(1) > Which is: 1 > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)