[ https://issues.apache.org/jira/browse/MESOS-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907246#comment-14907246 ]
Vaibhav Khanduja commented on MESOS-3392: ----------------------------------------- [~tnachen][~haosd...@gmail.com] Can we get this out? Review looks okay to me ... > Enhanced option for Docker cli volume plugin > -------------------------------------------- > > Key: MESOS-3392 > URL: https://issues.apache.org/jira/browse/MESOS-3392 > Project: Mesos > Issue Type: Improvement > Components: docker, slave > Affects Versions: 0.25.0 > Environment: Docker containers > Reporter: Vaibhav Khanduja > Assignee: haosdent > Priority: Minor > > Docker with 1.8 started to support volume plugin > (http://blog.docker.com/2015/06/extending-docker-with-plugins/) . This > support has enhanced cli for option "volume", where in an non-absolute name > of the volume can be provided. The name is passed by Docker daemon to backed > plugin in return for a mount point or absolute path of the volume. > The code in src/docker.cpp, for each volume provided it checks for the host > path which in above case if not starting with "/" gets prefixed with > "sandbox" location on the host. This breaks the volume plugin integration. > The only option now is to pass volume name as another key value parameter. > The code in docker.cpp: > ............................ > if (volume.has_host_path()) { > if (!strings::startsWith(volume.host_path(), "/")) { > // Support mapping relative paths from the sandbox. > volumeConfig = > path::join(sandboxDirectory, volume.host_path()) + ":" + > volumeConfig; > } else { > volumeConfig = volume.host_path() + ":" + volumeConfig; > } > ............... > should probably be enhanced to check if volume plugin option is provided and > pass on the parameter provided to the plugin. -- This message was sent by Atlassian JIRA (v6.3.4#6332)