[ 
https://issues.apache.org/jira/browse/MESOS-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Calmels updated MESOS-3522:
------------------------------------
    Description: 
Declining an offer through the MesosScheduler results in an empty task being 
accepted with no resources.
Extract from the master log: "Processing ACCEPT call for offers ..."

This is due to the implementation of declineOffer which effectively calls 
launchTasks with an empty TaskInfo list (sched.cpp:1926)
launchTasks currently emits a Call::ACCEPT, leading to Master::accept 
(master.cpp:2634)

Possible fixes include re-implementing declineOffer to emit a Call::DECLINE
or change the launchTasks function to use the LaunchTasksMessage.
I'm not really sure why there are two APIs (messages.proto and scheduler.proto) 
to do these tasks so I went with the later.

[https://reviews.apache.org/r/38778/]

Note the TODO would probably duplicate the code from acceptOffers.

  was:
Declining an offer through the MesosScheduler results in an empty task being 
accepted with no resources.
Extract from the master log: "Processing ACCEPT call for offers ..."

This is due to the implementation of declineOffer which effectively calls 
launchTasks with an empty TaskInfo list (sched.cpp:1926)
launchTasks currently emits a Call::ACCEPT, leading to Master::accept 
(master.cpp:2634)

Possible fixes include re-implementing declineOffer to emit a Call::DECLINE
or change the launchTasks function to use the LaunchTasksMessage.
I'm not really sure why there are two APIs (messages.proto and scheduler.proto) 
to do these tasks so I went with the later.

Note the TODO would probably duplicate the code from acceptOffers.


> MesosScheduler declineOffer results in an acceptOffer
> -----------------------------------------------------
>
>                 Key: MESOS-3522
>                 URL: https://issues.apache.org/jira/browse/MESOS-3522
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Jonathan Calmels
>            Priority: Minor
>
> Declining an offer through the MesosScheduler results in an empty task being 
> accepted with no resources.
> Extract from the master log: "Processing ACCEPT call for offers ..."
> This is due to the implementation of declineOffer which effectively calls 
> launchTasks with an empty TaskInfo list (sched.cpp:1926)
> launchTasks currently emits a Call::ACCEPT, leading to Master::accept 
> (master.cpp:2634)
> Possible fixes include re-implementing declineOffer to emit a Call::DECLINE
> or change the launchTasks function to use the LaunchTasksMessage.
> I'm not really sure why there are two APIs (messages.proto and 
> scheduler.proto) to do these tasks so I went with the later.
> [https://reviews.apache.org/r/38778/]
> Note the TODO would probably duplicate the code from acceptOffers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to