[ 
https://issues.apache.org/jira/browse/MESOS-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909928#comment-14909928
 ] 

Joris Van Remoortere commented on MESOS-3345:
---------------------------------------------

{code}
commit 3396a8e7919f4d2f44e3bef30e9838cc30ff9b4f
Author: Alex Clemmer <clemmer.alexan...@gmail.com>
Date:   Sun Sep 27 15:41:17 2015 -0700

    CMake: Updated CMake config to build Mesos against picojson v1.3.0.
    
    Review: https://reviews.apache.org/r/38531

commit a051fde5413f660aa6c32fd33a6c3687bb905687
Author: Alex Clemmer <clemmer.alexan...@gmail.com>
Date:   Sun Sep 27 15:41:15 2015 -0700

    CMake: Added preprocessor definitions required to build picojson 1.3.0.
    
    Review: https://reviews.apache.org/r/38530

commit 1eb0519eb1ffefb388e9ecad36e4b24413febcb8
Author: Alex Clemmer <clemmer.alexan...@gmail.com>
Date:   Sun Sep 27 15:41:14 2015 -0700

    CMake: Only compile proc_tests.cpp for Linux platforms.
    
    Review: https://reviews.apache.org/r/38529
{code}

> Expand the range of integer precision when converting into/out of json.
> -----------------------------------------------------------------------
>
>                 Key: MESOS-3345
>                 URL: https://issues.apache.org/jira/browse/MESOS-3345
>             Project: Mesos
>          Issue Type: Task
>          Components: stout
>            Reporter: Joseph Wu
>            Assignee: Joseph Wu
>            Priority: Minor
>              Labels: json, mesosphere, protobuf
>             Fix For: 0.25.0
>
>
> For [MESOS-3299], we added some protobufs to represent time with integer 
> precision.  However, this precision is not maintained through protobuf <-> 
> JSON conversion, because of how our JSON encoders/decoders convert numbers to 
> floating point.
> To maintain precision, we can try one of the following:
> * Try using a {{long double}} to represent a number.
> * Add logic to stringify/parse numbers without loss when possible.
> * Try representing {{int64_t}} as a string and parse it as such?
> * Update PicoJson and add a compiler flag, i.e. {{-DPICOJSON_USE_INT64}} 
> In all cases, we'll need to make sure that:
> * Integers are properly stringified without loss.
> * The JSON decoder parses the integer without loss.
> * We have some unit tests for big (close to {{INT32_MAX}}/{{INT64_MAX}}) and 
> small integers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to