[
https://issues.apache.org/jira/browse/MESOS-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14967270#comment-14967270
]
Joris Van Remoortere commented on MESOS-2953:
---------------------------------------------
{code}
commit 8de47a8ef27288d7660ee3a5e40874def912b8c2
Author: haosdent huang <haosd...@gmail.com>
Date: Wed Oct 21 10:56:16 2015 -0400
Removed unnecessary exec in post-rewrite hook.
Review: https://reviews.apache.org/r/39506
{code}
> git rebase --continue does not trigger hooks
> --------------------------------------------
>
> Key: MESOS-2953
> URL: https://issues.apache.org/jira/browse/MESOS-2953
> Project: Mesos
> Issue Type: Improvement
> Reporter: Joris Van Remoortere
> Assignee: haosdent
>
> Currently there are no git hooks run when executing {{git rebase
> --continue}}. We do run hooks on {{git commit}}.
> It would help prevent errors if we could also run some of these hooks on the
> {{git rebase --continue}} flow as this one is rather common.
> I believe we can use the 'post-rewrite' hook to accomplish this. It will not
> necessarily unwind the commit, but at least give us the opportunity to print
> warning messages.
> If this is not desirable / feasible I would like to propose running the hooks
> as part of post-reviews instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
