[ 
https://issues.apache.org/jira/browse/MESOS-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968658#comment-14968658
 ] 

Benjamin Bannier commented on MESOS-2275:
-----------------------------------------

I think we probably would also want an example that makes it clearer if in each 
component we use pure lex sort, or instead do enforce some residual level of 
logical ordering, e.g. {{clang-format}} (from trunk) prefers lexicographical 
sort

{code}
#include <foo/bar.hpp>
#include <foo.hpp>
{code}

while one could also imagine the opposite ordering which emphasizes {{foo.hpp}} 
as some sort of "heading header" (currently not supported by {{clang-format}}).

The Google style guide asks for "alphabetical ordering" which isn't helpful 
here.

> Document header include rules in style guide
> --------------------------------------------
>
>                 Key: MESOS-2275
>                 URL: https://issues.apache.org/jira/browse/MESOS-2275
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Niklas Quarfot Nielsen
>            Assignee: Jan Schlicht
>            Priority: Trivial
>              Labels: beginner, docathon, mesosphere
>
> We have several ways of sorting, grouping and ordering headers includes in 
> Mesos. We should agree on a rule set and do a style scan.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to