[
https://issues.apache.org/jira/browse/MESOS-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14971089#comment-14971089
]
Alexander Rukletsov commented on MESOS-3338:
--------------------------------------------
{{.reserved()}} indeed includes dynamically reserved resources. Would you agree
that having such non-trivial math for unused resources on an agent is not
optimal? I would suggest we revisit the types of resources we store to simplify
the math. How about [Total [Reserved] [Offered [Allocated [Used]]]] (Reserved
may overlap with offered, allocated and used)?
> Dynamic reservations are not counted as used resources in the master
> --------------------------------------------------------------------
>
> Key: MESOS-3338
> URL: https://issues.apache.org/jira/browse/MESOS-3338
> Project: Mesos
> Issue Type: Bug
> Components: allocation, master
> Reporter: Alexander Rukletsov
> Assignee: Guangya Liu
> Priority: Minor
> Labels: mesosphere, persistent-volumes
>
> Dynamically reserved resources should be considered used or allocated and
> hence reflected in Mesos bookkeeping structures and {{state.json}}.
> I expanded the {{ReservationTest.ReserveThenUnreserve}} test with the
> following section:
> {code}
> // Check that the Master counts the reservation as a used resource.
> {
> Future<process::http::Response> response =
> process::http::get(master.get(), "state.json");
> AWAIT_READY(response);
> Try<JSON::Object> parse = JSON::parse<JSON::Object>(response.get().body);
> ASSERT_SOME(parse);
> Result<JSON::Number> cpus =
> parse.get().find<JSON::Number>("slaves[0].used_resources.cpus");
> ASSERT_SOME_EQ(JSON::Number(1), cpus);
> }
> {code}
> and got
> {noformat}
> ../../../src/tests/reservation_tests.cpp:168: Failure
> Value of: (cpus).get()
> Actual: 0
> Expected: JSON::Number(1)
> Which is: 1
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
