[ 
https://issues.apache.org/jira/browse/MESOS-3843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007441#comment-15007441
 ] 

Diana Arroyo commented on MESOS-3843:
-------------------------------------

List of cpp/hpp files found in src/Makefile.am not found in src/CMakeLists.txt:

messages/messages.cpp
slave/containerizer/mesos/provisioner/docker/local_puller.cpp
slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp
slave/containerizer/mesos/provisioner/docker/paths.cpp
slave/containerizer/mesos/provisioner/docker/puller.cpp
slave/containerizer/mesos/provisioner/docker/store.cpp
authentication/cram_md5/authenticatee.hpp
authentication/cram_md5/authenticator.hpp
authentication/cram_md5/auxprop.hpp
authorizer/local/authorizer.hpp
common/build.hpp
common/date_utils.hpp
common/http.hpp
common/parse.hpp
common/protobuf_utils.hpp
common/recordio.hpp
common/resources_utils.hpp
common/status_utils.hpp
credentials/credentials.hpp
examples/test_anonymous_module.hpp
examples/test_module.hpp
examples/utils.hpp
files/files.hpp
hdfs/hdfs.hpp
hook/manager.hpp
internal/devolve.hpp
internal/evolve.hpp
local/flags.hpp
local/local.hpp
logging/flags.hpp
logging/logging.hpp
master/constants.hpp
master/contender.hpp
master/detector.hpp
master/flags.hpp
master/machine.hpp
master/maintenance.hpp
master/master.hpp
master/metrics.hpp
master/registrar.hpp
master/repairer.hpp
master/validation.hpp
master/allocator/mesos/allocator.hpp
master/allocator/mesos/hierarchical.hpp
master/allocator/sorter/sorter.hpp
master/allocator/sorter/drf/sorter.hpp
messages/flags.hpp
messages/messages.hpp
module/manager.hpp
sched/constants.hpp
sched/flags.hpp
slave/constants.hpp
slave/flags.hpp
slave/gc.hpp
slave/metrics.hpp
slave/monitor.hpp
slave/paths.hpp
slave/slave.hpp
slave/state.hpp
slave/status_update_manager.hpp
slave/validation.hpp
slave/containerizer/containerizer.hpp
slave/containerizer/external_containerizer.hpp
slave/containerizer/fetcher.hpp
slave/containerizer/isolator.hpp
slave/containerizer/mesos/containerizer.hpp
slave/containerizer/mesos/launch.hpp
slave/containerizer/mesos/launcher.hpp
slave/containerizer/mesos/mount.hpp
slave/containerizer/mesos/isolators/posix.hpp
slave/containerizer/mesos/isolators/filesystem/posix.hpp
slave/containerizer/mesos/isolators/posix/disk.hpp
slave/containerizer/mesos/provisioner/backend.hpp
slave/containerizer/mesos/provisioner/paths.hpp
slave/containerizer/mesos/provisioner/provisioner.hpp
slave/containerizer/mesos/provisioner/store.hpp
slave/containerizer/mesos/provisioner/appc/paths.hpp
slave/containerizer/mesos/provisioner/appc/spec.hpp
slave/containerizer/mesos/provisioner/appc/store.hpp
slave/containerizer/mesos/provisioner/backends/copy.hpp
slave/containerizer/mesos/provisioner/docker/local_puller.hpp
slave/containerizer/mesos/provisioner/docker/message.hpp
slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp
slave/containerizer/mesos/provisioner/docker/paths.hpp
slave/containerizer/mesos/provisioner/docker/puller.hpp
slave/containerizer/mesos/provisioner/docker/registry_client.hpp
slave/containerizer/mesos/provisioner/docker/registry_puller.hpp
slave/containerizer/mesos/provisioner/docker/spec.hpp
slave/containerizer/mesos/provisioner/docker/store.hpp
slave/containerizer/mesos/provisioner/docker/token_manager.hpp
slave/qos_controllers/noop.hpp
slave/resource_estimators/noop.hpp
tests/allocator.hpp
tests/cluster.hpp
tests/containerizer.hpp
tests/environment.hpp
tests/flags.hpp
tests/limiter.hpp
tests/mesos.hpp
tests/module.hpp
tests/script.hpp
tests/utils.hpp
tests/zookeeper.hpp
tests/zookeeper_test_server.hpp
tests/containerizer/isolator.hpp
tests/containerizer/launcher.hpp
tests/containerizer/memory_test_helper.hpp
tests/containerizer/rootfs.hpp
tests/containerizer/setns_test_helper.hpp
tests/containerizer/store.hpp
usage/usage.hpp
version/version.hpp
watcher/whitelist_watcher.hpp
zookeeper/authentication.hpp
zookeeper/contender.hpp
zookeeper/detector.hpp
zookeeper/group.hpp
zookeeper/url.hpp
zookeeper/watcher.hpp
zookeeper/zookeeper.hpp
linux/cgroups.cpp
linux/fs.cpp
linux/perf.cpp
linux/systemd.cpp
slave/containerizer/mesos/linux_launcher.cpp
slave/containerizer/mesos/isolators/cgroups/cpushare.cpp
slave/containerizer/mesos/isolators/cgroups/mem.cpp
slave/containerizer/mesos/isolators/cgroups/perf_event.cpp
slave/containerizer/mesos/isolators/filesystem/linux.cpp
slave/containerizer/mesos/isolators/filesystem/shared.cpp
slave/containerizer/mesos/isolators/namespaces/pid.cpp
slave/containerizer/mesos/provisioner/backends/bind.cpp
linux/cgroups.hpp
linux/fs.hpp
linux/ns.hpp
linux/perf.hpp
linux/sched.hpp
linux/systemd.hpp
slave/containerizer/mesos/linux_launcher.hpp
slave/containerizer/mesos/isolators/cgroups/constants.hpp
slave/containerizer/mesos/isolators/cgroups/cpushare.hpp
slave/containerizer/mesos/isolators/cgroups/mem.hpp
slave/containerizer/mesos/isolators/cgroups/perf_event.hpp
slave/containerizer/mesos/isolators/filesystem/linux.hpp
slave/containerizer/mesos/isolators/filesystem/shared.hpp
slave/containerizer/mesos/isolators/namespaces/pid.hpp
slave/containerizer/mesos/provisioner/backends/bind.hpp
linux/routing/route.cpp
linux/routing/utils.cpp
linux/routing/diagnosis/diagnosis.cpp
linux/routing/filter/basic.cpp
linux/routing/filter/icmp.cpp
linux/routing/filter/ip.cpp
linux/routing/link/link.cpp
linux/routing/queueing/fq_codel.cpp
linux/routing/queueing/htb.cpp
linux/routing/queueing/ingress.cpp
slave/containerizer/mesos/isolators/network/port_mapping.cpp
linux/routing/handle.hpp
linux/routing/internal.hpp
linux/routing/route.hpp
linux/routing/utils.hpp
linux/routing/diagnosis/diagnosis.hpp
linux/routing/filter/action.hpp
linux/routing/filter/basic.hpp
linux/routing/filter/filter.hpp
linux/routing/filter/handle.hpp
linux/routing/filter/icmp.hpp
linux/routing/filter/internal.hpp
linux/routing/filter/ip.hpp
linux/routing/filter/priority.hpp
linux/routing/link/internal.hpp
linux/routing/link/link.hpp
linux/routing/queueing/discipline.hpp
linux/routing/queueing/fq_codel.hpp
linux/routing/queueing/htb.hpp
linux/routing/queueing/ingress.hpp
linux/routing/queueing/internal.hpp
linux/routing/queueing/statistics.hpp
slave/containerizer/mesos/isolators/network/port_mapping.hpp
common/build.cpp
log/catchup.cpp
log/consensus.cpp
log/coordinator.cpp
log/leveldb.cpp
log/log.cpp
log/recover.cpp
log/replica.cpp
log/tool/benchmark.cpp
log/tool/initialize.cpp
log/tool/read.cpp
log/tool/replica.cpp
log/catchup.hpp
log/consensus.hpp
log/coordinator.hpp
log/leveldb.hpp
log/log.hpp
log/network.hpp
log/recover.hpp
log/replica.hpp
log/storage.hpp
log/tool.hpp
log/tool/benchmark.hpp
log/tool/initialize.hpp
log/tool/read.hpp
log/tool/replica.hpp
messages/log.hpp
state/in_memory.cpp
state/leveldb.cpp
state/log.cpp
state/zookeeper.cpp
state/in_memory.hpp
state/leveldb.hpp
state/log.hpp
state/protobuf.hpp
state/state.hpp
state/storage.hpp
state/zookeeper.hpp
messages/state.hpp
master/main.cpp
slave/main.cpp
local/main.cpp
launcher/fetcher.cpp
launcher/executor.cpp
slave/containerizer/mesos/main.cpp
slave/containerizer/mesos/isolators/network/helper.cpp
health-check/main.cpp
usage/main.cpp
docker/executor.cpp
log/main.cpp
cli/mesos.cpp
cli/execute.cpp
cli/resolve.cpp
java/jni/convert.cpp
java/jni/convert.hpp
java/jni/construct.cpp
java/jni/construct.hpp
java/jni/org_apache_mesos_Log.cpp
java/jni/org_apache_mesos_MesosExecutorDriver.cpp
java/jni/org_apache_mesos_MesosNativeLibrary.cpp
java/jni/org_apache_mesos_MesosSchedulerDriver.cpp
java/jni/org_apache_mesos_state_AbstractState.cpp
java/jni/org_apache_mesos_state_LevelDBState.cpp
java/jni/org_apache_mesos_state_LogState.cpp
java/jni/org_apache_mesos_state_Variable.cpp
java/jni/org_apache_mesos_state_ZooKeeperState.cpp
jvm/jvm.cpp
jvm/jvm.hpp
jvm/java/io.hpp
jvm/java/lang.hpp
jvm/java/net.hpp
jvm/org/apache/log4j.cpp
jvm/org/apache/log4j.hpp
jvm/org/apache/zookeeper.cpp
jvm/org/apache/zookeeper.hpp
python/native/src/mesos/native/mesos_executor_driver_impl.cpp
python/native/src/mesos/native/mesos_executor_driver_impl.hpp
python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp
python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp
python/native/src/mesos/native/module.cpp
python/native/src/mesos/native/module.hpp
python/native/src/mesos/native/proxy_executor.cpp
python/native/src/mesos/native/proxy_executor.hpp
python/native/src/mesos/native/proxy_scheduler.cpp
python/native/src/mesos/native/proxy_scheduler.hpp
examples/event_call_framework.cpp
examples/test_framework.cpp
examples/test_executor.cpp
examples/long_lived_framework.cpp
examples/long_lived_executor.cpp
examples/no_executor_framework.cpp
examples/docker_no_executor_framework.cpp
examples/balloon_framework.cpp
examples/balloon_executor.cpp
examples/load_generator_framework.cpp
examples/persistent_volume_framework.cpp
tests/containerizer/setns_test_helper_main.cpp
tests/containerizer/setns_test_helper.cpp
tests/flags.cpp
tests/containerizer/memory_test_helper_main.cpp
tests/containerizer/memory_test_helper.cpp
tests/active_user_test_helper.cpp
slave/resource_estimators/fixed.cpp
examples/example_module_impl.cpp
examples/test_anonymous_module.cpp
examples/test_authentication_modules.cpp
examples/test_authorizer_module.cpp
examples/test_allocator_module.cpp
examples/test_hook_module.cpp
examples/test_isolator_module.cpp
examples/test_resource_estimator_module.cpp
examples/test_qos_controller_module.cpp
tests/anonymous_tests.cpp
tests/attributes_tests.cpp
tests/authentication_tests.cpp
tests/authorization_tests.cpp
tests/cluster.cpp
tests/containerizer.cpp
tests/cram_md5_authentication_tests.cpp
tests/credentials_tests.cpp
tests/disk_quota_tests.cpp
tests/environment.cpp
tests/examples_tests.cpp
tests/exception_tests.cpp
tests/executor_http_api_tests.cpp
tests/fault_tolerance_tests.cpp
tests/fetcher_cache_tests.cpp
tests/fetcher_tests.cpp
tests/files_tests.cpp
tests/flags.cpp
tests/gc_tests.cpp
tests/health_check_tests.cpp
tests/hierarchical_allocator_tests.cpp
tests/hook_tests.cpp
tests/log_tests.cpp
tests/logging_tests.cpp
tests/main.cpp
tests/master_allocator_tests.cpp
tests/master_authorization_tests.cpp
tests/master_contender_detector_tests.cpp
tests/master_maintenance_tests.cpp
tests/master_slave_reconciliation_tests.cpp
tests/master_tests.cpp
tests/master_validation_tests.cpp
tests/mesos.cpp
tests/metrics_tests.cpp
tests/module.cpp
tests/module_tests.cpp
tests/monitor_tests.cpp
tests/oversubscription_tests.cpp
tests/partition_tests.cpp
tests/paths_tests.cpp
tests/persistent_volume_tests.cpp
tests/protobuf_io_tests.cpp
tests/rate_limiting_tests.cpp
tests/reconciliation_tests.cpp
tests/registrar_tests.cpp
tests/repair_tests.cpp
tests/reservation_endpoints_tests.cpp
tests/reservation_tests.cpp
tests/resource_offers_tests.cpp
tests/resources_tests.cpp
tests/scheduler_driver_tests.cpp
tests/scheduler_event_call_tests.cpp
tests/scheduler_http_api_tests.cpp
tests/scheduler_tests.cpp
tests/script.cpp
tests/slave_recovery_tests.cpp
tests/slave_tests.cpp
tests/sorter_tests.cpp
tests/state_tests.cpp
tests/status_update_manager_tests.cpp
tests/teardown_tests.cpp
tests/utils.cpp
tests/values_tests.cpp
tests/zookeeper_url_tests.cpp
tests/common/http_tests.cpp
tests/common/recordio_tests.cpp
tests/containerizer/composing_containerizer_tests.cpp
tests/containerizer/docker_containerizer_tests.cpp
tests/containerizer/docker_tests.cpp
tests/containerizer/external_containerizer_test.cpp
tests/containerizer/isolator_tests.cpp
tests/containerizer/memory_test_helper.cpp
tests/containerizer/mesos_containerizer_tests.cpp
tests/containerizer/provisioner_appc_tests.cpp
tests/containerizer/provisioner_backend_tests.cpp
tests/containerizer/provisioner_docker_tests.cpp
tests/containerizer/cgroups_isolator_tests.cpp
tests/containerizer/cgroups_tests.cpp
tests/containerizer/filesystem_isolator_tests.cpp
tests/containerizer/fs_tests.cpp
tests/containerizer/launch_tests.cpp
tests/containerizer/memory_pressure_tests.cpp
tests/containerizer/ns_tests.cpp
tests/containerizer/perf_tests.cpp
tests/containerizer/sched_tests.cpp
tests/containerizer/setns_test_helper.cpp
tests/containerizer/port_mapping_tests.cpp
tests/containerizer/routing_tests.cpp
tests/group_tests.cpp
tests/registrar_zookeeper_tests.cpp
tests/zookeeper.cpp
tests/zookeeper_test_server.cpp
tests/zookeeper_tests.cpp


> Audit `src/CMakelists.txt` to make sure we're compiling everything we need to 
> build the agent binary.
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MESOS-3843
>                 URL: https://issues.apache.org/jira/browse/MESOS-3843
>             Project: Mesos
>          Issue Type: Task
>          Components: cmake
>            Reporter: Alex Clemmer
>            Assignee: Diana Arroyo
>
> `src/CMakeLists.txt` has fallen into some state of disrepair. There are some 
> source files that seem to be missing (e.g., the `src/launcher/` and 
> `src/linux`/ directories), so the first step is to audit the source file to 
> make sure everything we need is there. Likely this will mean looking at the 
> corresponding `src/Makefile.am` to see that's missing.
> Once we understand the limitations of the current build, we can fan out more 
> tickets or proceed to generating the agent binary, as well as the master.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to